Windows: Enable OpenPGL on ARM64 machines #127705

Anthony Roberts · 2024-09-16T16:36:39+02:00

Anthony Roberts commented

2024-09-16 16:36:39 +02:00

This is the last remaining feature on #119126, which means with this merged, we would be feature complete (other than GPU rendering, but there is little indication of that being possible any time soon), and on feature parity with other platforms.

As OpenPGL ships with it's own version of embree, I had to pull the same trick that embree itself uses in the deps build system, where it is built with clang-cl as produced by compiling LLVM as it's own dep.

The OpenPGL patch updates sse2neon, manually re-adds the openPGL modifications to sse2neon that are there right now, and also fixes a few bugs preventing compilation on Windows ARM64 (CMake fixes and a few defines).

The updated TBB patch is required to build OpenPGL with clang-cl due to this bug. Once we finally shift off TBB 2020u3 this can go away, along with a good chunk of the rest of the TBB patch.

I have a PR to OpenPGL open, but Sebastian thinks the release window for that might be cutting it a little close to Bcon3, so suggested I make this PR including the patch.

This is the last remaining feature on #119126, which means with this merged, we would be feature complete (other than GPU rendering, but there is little indication of that being possible any time soon), and on feature parity with other platforms. As OpenPGL ships with it's own version of embree, I had to pull the same trick that embree itself uses in the deps build system, where it is built with clang-cl as produced by compiling LLVM as it's own dep. The OpenPGL patch updates sse2neon, manually re-adds the openPGL modifications to sse2neon that are there right now, and also fixes a few bugs preventing compilation on Windows ARM64 (CMake fixes and a few defines). The updated TBB patch is required to build OpenPGL with clang-cl due to [this bug](https://github.com/oneapi-src/oneTBB/issues/1142). Once we finally shift off TBB 2020u3 this can go away, along with a good chunk of the rest of the TBB patch. I have a [PR to OpenPGL open](https://github.com/RenderKit/openpgl/pull/17), but Sebastian thinks the release window for that might be cutting it a little close to Bcon3, so suggested I make this PR including the patch.

Anthony Roberts added 1 commit 2024-09-16 16:36:42 +02:00

Windows: Enable OpenPGL on ARM64 machines e80ee34752

Anthony Roberts requested review from Ray molenkamp 2024-09-16 16:36:56 +02:00

Ray molenkamp approved these changes 2024-09-16 16:47:18 +02:00

Anthony Roberts merged commit f0de0bc8d3 into main

2024-09-17 14:57:29 +02:00

Anthony Roberts referenced this issue from a commit

2024-09-17 14:57:31 +02:00

Windows: Enable OpenPGL on ARM64 machines

Anthony Roberts deleted branch enable-openpgl

2024-09-17 14:57:33 +02:00

Anthony Roberts referenced this pull request