Fix #127691: Crash assigning null to active attribute #127744

Pratik Borhade · 2024-09-17T07:53:43+02:00

Pratik Borhade commented

2024-09-17 07:53:43 +02:00

This is due to missing null check

Pratik Borhade added 1 commit 2024-09-17 07:53:53 +02:00

Fix #127691 : Crash assigning null to active_color f7b4797c97

This is due to missing null check

Pratik Borhade requested review from Hans Goudey 2024-09-17 07:54:17 +02:00

Pratik Borhade commented

2024-09-17 07:54:30 +02:00

or maybe we could use PROP_NEVER_NULL flag?

or maybe we could use `PROP_NEVER_NULL` flag?

Pratik Borhade changed title from ~~Fix #127691: Crash assigning null to active_color~~ to Fix #127691: Crash assigning null to active attribute

2024-09-17 07:55:43 +02:00

Andrej commented

2024-09-17 08:02:36 +02:00

or maybe we could use PROP_NEVER_NULL flag?

But they can be null:
C.object.data.attributes.active_color in new project's Cube is None.
C.object.data.attributes.active is also can be None - e.g. when you remove some attribute from UI then attributes.active becomes None until user selects some other one.

> or maybe we could use `PROP_NEVER_NULL` flag? But they can be null: `C.object.data.attributes.active_color` in new project's Cube is `None`. `C.object.data.attributes.active` is also can be `None` - e.g. when you remove some attribute from UI then `attributes.active` becomes `None` until user selects some other one.

Pratik Borhade commented

2024-09-17 10:08:32 +02:00

So I assume current fix is correct?

Hans Goudey reviewed 2024-09-17 21:26:17 +02:00

Hans Goudey left a comment

I think it might be simpler to allow having no active attribute. That already happens in some cases currently.

For the color attributes, I think it would be better to free the attribute name stored on the mesh.

For the active attribute, it might be good to check if there's a proper "not set" value. Maybe setting the active attribute index to -1 or something could represent this state.

I think it might be simpler to allow having no active attribute. That already happens in some cases currently. For the color attributes, I think it would be better to free the attribute name stored on the mesh. For the active attribute, it might be good to check if there's a proper "not set" value. Maybe setting the active attribute index to `-1` or something could represent this state.

Campbell Barton commented

2024-09-20 07:02:07 +02:00

Agree "no active" being represented by -1 makes sense, checking geometry_attribute_remove_exec it looks like this is currently avoided (never below zero), but that can be changed.

Agree "no active" being represented by -1 makes sense, checking `geometry_attribute_remove_exec` it looks like this is currently avoided (never below zero), but that can be changed.

Campbell Barton commented

2024-09-27 09:15:36 +02:00

Submitted an alternate patch which supports clearing the active layer: #128233.

👍 1

Pratik Borhade commented

2024-09-27 12:21:59 +02:00

Thanks, I'll close this PR.

Pratik Borhade closed this pull request

2024-09-27 12:22:10 +02:00

Pratik Borhade deleted branch 127691-colattr-crash

2024-09-27 12:23:24 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #127691: Crash assigning null to active attribute #127744

Pull request closed