Nodes: Improve matches when dragging a node onto a link #127868

Charlie Jolly · 2024-09-19T17:14:53+02:00

Charlie Jolly commented

2024-09-19 17:14:53 +02:00

This patch adds a new 'get_main_socket_by_type' function to match
the node sockets more precisely when dragging a node onto
a pre-existing link.

This resolves some cases when nodes are unable to drag link when there
are suitable sockets available. E.g. a menu socket in a group node would
prevent the next available socket from being used.
This was previously investigated in #127717.

Previously, the get_main_socket function matched sockets as follows.

Socket declaration is_default_link_socket flag
Sockets matched by highest priority node socket*
Validate link

The new function matches sockets as follows.

Socket declaration is_default_link_socket flag (same as before)
Sockets matched by exact type with link socket*
Sockets matched by first lower type than link socket.*^
Sockets matched by highest priority node socket* (same as before)
Validate link (same as before)

*Visible node sockets, then hidden node sockets
^This is only for RGBA sockets and below.

Matching by name was not considered as it would have required
some hard coding of socket names.

Before	After	Comment
		Node is now able to attach to the link by matching the type
		Node is now able to attach

This patch adds a new 'get_main_socket_by_type' function to match the node sockets more precisely when dragging a node onto a pre-existing link. This resolves some cases when nodes are unable to drag link when there are suitable sockets available. E.g. a menu socket in a group node would prevent the next available socket from being used. This was previously investigated in #127717. Previously, the `get_main_socket` function matched sockets as follows. 1) Socket declaration `is_default_link_socket` flag 2) Sockets matched by highest priority node socket* 3) Validate link The new function matches sockets as follows. 1) Socket declaration `is_default_link_socket` flag (same as before) 2) Sockets matched by exact type with link socket* 3) Sockets matched by first lower type than link socket.*^ 4) Sockets matched by highest priority node socket* (same as before) 5) Validate link (same as before) *Visible node sockets, then hidden node sockets ^This is only for RGBA sockets and below. Matching by name was not considered as it would have required some hard coding of socket names. | Before | After | Comment | | -------- | -------- | -------- | | <img width="200" alt="image" src="attachments/25ac8c87-1111-4cbb-bbb0-5722386c7c10"> | <img width="200" alt="image" src="attachments/e85d1174-2e82-4cf9-9a05-efc3682471ca"> | Node is now able to attach to the link by matching the type | | <img width="200" alt="image" src="attachments/64ba63ad-cde4-479f-ac2f-bac1f3d53444"> | <img width="200" alt="image" src="attachments/1a189e3d-c047-4cf0-8fd8-52995c3e6c01"> | Node is now able to attach |

image.png

33 KiB

image.png

31 KiB

image.png

32 KiB

image.png

33 KiB

❤️ 5 🎉 1

Charlie Jolly added 1 commit 2024-09-19 17:15:03 +02:00

Nodes: Improve matches when dragging a node onto a link 0ad4094e84

This patch adds a new 'get_main_socket_by_type' function to match
the node sockets more precisely with the link.

This resolves some cases when nodes are unabel to drag link when there
are suitable sockets available. E.g. a menu socket in a group node would
prevent. This was previously investigated in #127717.

Previously, the `get_main_socket` function matched sockets as follows.
1) Socket declaration `is_default_link_socket` flag
2) Sockets matched by highest priority node socket*
3) Validate link

The new function matches sockets as follows.
1) Socket declaration `is_default_link_socket` flag (same as before)
2) Sockets matched by exact type with link socket*
3) Sockets matched by first lower type than link socket*
4) Sockets matched by highest priority node socket* (same as before)
5) Validate link (same as before)

* Visible node sockets, then hidden node sockets

Matching be name was not considered as it would have required
some hard coding of socket names.

Charlie Jolly added this to the Nodes & Physics project 2024-09-19 17:15:22 +02:00

Charlie Jolly modified the project from Nodes & Physics to User Interface

2024-09-19 17:15:27 +02:00

Charlie Jolly modified the project from User Interface to Nodes & Physics

2024-09-19 17:15:35 +02:00

Charlie Jolly added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Nodes: Improve matches when dragging a node onto a link #127868

Checkout