Spreadsheet: use more obvious fallback name for geometries #128207

Jacques Lucke · 2024-09-26T19:55:51+02:00

Jacques Lucke commented

2024-09-26 19:55:51 +02:00

Instead of Geometry, the fallback name is now (Geometry). The goal is to make it more obvious that this is not the actual name, but just a fallback. With some luck it also motivates people to use better custom names.

This was discussed in #127873 (comment). There we do the same thing with (Layer) for Grease Pencil.

Instead of `Geometry`, the fallback name is now `(Geometry)`. The goal is to make it more obvious that this is not the actual name, but just a fallback. With some luck it also motivates people to use better custom names. This was discussed in https://projects.blender.org/blender/blender/pulls/127873#issuecomment-1303765. There we do the same thing with `(Layer)` for Grease Pencil.

👍 1

Jacques Lucke added 1 commit 2024-09-26 19:56:03 +02:00

change fallback name 4ab9793e85

Jacques Lucke requested review from Simon Thommes 2024-09-26 19:57:18 +02:00

Jacques Lucke requested review from Hans Goudey 2024-09-26 19:57:18 +02:00

Simon Thommes requested changes 2024-09-27 11:39:03 +02:00

Dismissed

Simon Thommes left a comment

Just talked about this with Dalai and he suggested graying out the name.
I wouldn't just gray it out but do both. Could you try that in this PR?

Just talked about this with Dalai and he suggested graying out the name. I wouldn't just gray it out but do both. Could you try that in this PR?

Nika Kutsniashvili commented

2024-09-27 11:41:22 +02:00

Changing color might make it more difficult to read on some themes with grey backgrounds. How about italics?

Simon Thommes commented

2024-09-27 12:04:31 +02:00

Maybe you can include the graying out also in regard to the GP layers as seen in blender/blender!127873 once that is merged in this PR, so we can separate that topic a bit and merge that already?

Simon Thommes commented

2024-09-27 12:07:10 +02:00

Changing color might make it more difficult to read on some themes with grey backgrounds. How about italics?

I think that is acceptable, since this is only the case with the generic fallback, where reading it is not actually that important

> Changing color might make it more difficult to read on some themes with grey backgrounds. How about italics? I think that is acceptable, since this is only the case with the generic fallback, where reading it is not actually that important

Pablo Vazquez commented

2024-09-27 17:22:48 +02:00

Using parentheses communicates it well enough I think. +1

I would avoid using italics since we don't really use them anywhere yet and introducing this here could limit us using that elsewhere (it was proposed once to use italics in the Outliner to tell apart linked objects in multiple collections).

Using parentheses communicates it well enough I think. +1 I would avoid using italics since we don't really use them anywhere yet and introducing this here could limit us using that elsewhere (it was proposed once to use italics in the Outliner to tell apart linked objects in multiple collections).

Jacques Lucke commented

2024-09-27 21:56:56 +02:00

Ok, I'm unsure whether to use parenthesis or graying out now.
Personally, I also find graying out somewhat problematic because it usually means something like "inactive" which is a different concept.

Ok, I'm unsure whether to use parenthesis or graying out now. Personally, I also find graying out somewhat problematic because it usually means something like "inactive" which is a different concept.

Simon Thommes approved these changes 2024-09-30 10:15:12 +02:00

Simon Thommes left a comment

I also don't think the graying out is necessary. It was an idea by Dalai, that I though we could try. But if Pablo and you already agree to go without, that is fine with me as well.

It does look a bit odd at first that there are parentheses in the default case, but at least now the fallback is communicated and just having Geometry a bunch of times without parentheses is not exactly much better.
It's unfortunate that we can't have tooltips to add some clarification to why this is.

I also don't think the graying out is necessary. It was an idea by Dalai, that I though we could try. But if Pablo and you already agree to go without, that is fine with me as well. It does look a bit odd at first that there are parentheses in the default case, but at least now the fallback is communicated and just having `Geometry` a bunch of times without parentheses is not exactly much better. It's unfortunate that we can't have tooltips to add some clarification to why this is.

Jacques Lucke commented

2024-09-30 11:17:10 +02:00

It's unfortunate that we can't have tooltips to add some clarification to why this is.

Not sure it's impossible to have tooltips, will have to check this.

> It's unfortunate that we can't have tooltips to add some clarification to why this is. Not sure it's impossible to have tooltips, will have to check this.

❤️ 1

Jacques Lucke merged commit 13391c14d8 into main

2024-09-30 11:18:17 +02:00

Jacques Lucke referenced this issue from a commit

2024-09-30 11:18:19 +02:00

Spreadsheet: use more obvious fallback name for geometries

Jacques Lucke deleted branch new-geometry-fallback-name

2024-09-30 11:18:21 +02:00

Clément Foucault referenced this issue from a commit

2024-09-30 14:17:27 +02:00

Spreadsheet: use more obvious fallback name for geometries

Lukas Tönne referenced this issue from a commit