blender/blender
164
517
Fork 783
Code Issues 6.8k Pull Requests 938 Projects 19 Wiki Activity

Fix #126562: Cycles/EEVEE versioning #128554

Merged
Miguel Pozo merged 3 commits from pragma37/blender:pull-fix-126562 into blender-v4.3-release 2024-10-07 12:12:52 +02:00
Conversation 0 Commits 3 Files Changed 1 +28 -21
Miguel Pozo commented 2024-10-03 20:34:35 +02:00
Member
Copy Link

Check all scenes to decide between versioning merged settings using
EEVEE or Cycles properties.

Still far from a great solution. :(

Check all scenes to decide between versioning merged settings using EEVEE or Cycles properties. Still far from a great solution. :(
Miguel Pozo added the
Module
Render & Cycles
Interest
Viewport & EEVEE
Interest
EEVEE
 labels 2024-10-03 20:34:36 +02:00
Miguel Pozo added 1 commit 2024-10-03 20:34:49 +02:00
Miguel Pozo requested review from Sergey Sharybin 2024-10-03 20:35:53 +02:00
Miguel Pozo requested review from Clément Foucault 2024-10-03 20:35:53 +02:00
Sergey Sharybin requested changes 2024-10-04 11:14:48 +02:00
Dismissed
Sergey Sharybin left a comment
Owner
Copy Link

From the readability perspective having a function which changes its entire behavior based on a boolean flag is quite bad. Split the function in two, and it will make it easier to follow the function itself, but also the uses of the function:

only_uses_eevee(bmain, true) -> is_only_legacy_eevee_used(bmain)
only_uses_eevee(bmain, false) -> is_only_any_eevee_used(bmain)

There maybe even better naming, but anything will be better than seeing true/false in the function call without any other way to understand semantic.

From the readability perspective having a function which changes its entire behavior based on a boolean flag is quite bad. Split the function in two, and it will make it easier to follow the function itself, but also the uses of the function: `only_uses_eevee(bmain, true)` -> `is_only_legacy_eevee_used(bmain)` `only_uses_eevee(bmain, false)` -> `is_only_any_eevee_used(bmain)` There maybe even better naming, but anything will be better than seeing `true`/`false` in the function call without any other way to understand semantic.
Miguel Pozo added 1 commit 2024-10-04 15:49:32 +02:00
Sergey Sharybin reviewed 2024-10-04 16:12:33 +02:00
source/blender/blenloader/intern/versioning_400.cc Outdated
@ -1003,6 +1003,27 @@ static bool versioning_convert_strip_speed_factor(Sequence *seq, void *user_data
return true;
}
static bool all_scenes_use(Main *bmain, blender::Vector<const char *> engines)
Sergey Sharybin commented 2024-10-04 16:12:31 +02:00
Owner
Copy Link

const blender::Span<const char *> engines

`const blender::Span<const char *> engines`
pragma37 marked this conversation as resolved
Miguel Pozo added 1 commit 2024-10-04 17:14:00 +02:00
Sergey Sharybin approved these changes 2024-10-04 17:26:52 +02:00
Clément Foucault approved these changes 2024-10-07 12:10:37 +02:00
Miguel Pozo changed target branch from main to blender-v4.3-release 2024-10-07 12:12:24 +02:00
Miguel Pozo merged commit 88289e8bac into blender-v4.3-release 2024-10-07 12:12:52 +02:00
Miguel Pozo deleted branch pull-fix-126562 2024-10-07 12:13:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Sergey Sharybin
Clément Foucault
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#128554
No description provided.
Delete Branch "pragma37/blender:pull-fix-126562"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?