blender/blender

Fix: Crash with a BadAccess X_GLXMakeCurrent error #129793

Merged

Omar Emara merged 1 commits from OmarEmaraDev/blender:release-render-context-on-ensure into main

2024-11-04 16:17:38 +01:00

Omar Emara commented

2024-11-04 13:34:16 +01:00

Member

Blender crashes when opening files that invokes the interactive
compositor on file load with a BadAccess X_GLXMakeCurrent error.

This is caused by the same system GPU context being active in two
threads at the same time, which happens when the GPU context for the
compositor is created in the main thread, it is made current during
creation, but it is not reset to the main GPU context of the drawable
because it is null. So when the GPU compositor actually executes, it
makes the GPU context current again but in its own thread, causing a
BadAccess error in X11 and potentially other window systems.

So the root cause is that the drawable is nullptr, and an attempt to fix
this was committed in 0a70360eb6 but was reverted in 98722773da because
it caused serious issue that were not obvious.

This patch attempts another fix by simply releasing the system GPU
context created when calling the RE_system_gpu_context_ensure. This is
more robust anyways because callers do not expect the context to be
bound form an API point of view.

Blender crashes when opening files that invokes the interactive compositor on file load with a BadAccess X_GLXMakeCurrent error. This is caused by the same system GPU context being active in two threads at the same time, which happens when the GPU context for the compositor is created in the main thread, it is made current during creation, but it is not reset to the main GPU context of the drawable because it is null. So when the GPU compositor actually executes, it makes the GPU context current again but in its own thread, causing a BadAccess error in X11 and potentially other window systems. So the root cause is that the drawable is nullptr, and an attempt to fix this was committed in 0a70360eb6 but was reverted in 98722773da because it caused serious issue that were not obvious. This patch attempts another fix by simply releasing the system GPU context created when calling the RE_system_gpu_context_ensure. This is more robust anyways because callers do not expect the context to be bound form an API point of view.

Omar Emara added the

Viewport & EEVEE

Viewport & EEVEE

labels 2024-11-04 13:34:16 +01:00

Omar Emara added 1 commit 2024-11-04 13:34:26 +01:00

Fix: Crash with a BadAccess X_GLXMakeCurrent error 73f4f88ee3

Blender crashes when opening files that invokes the interactive
compositor on file load with a BadAccess X_GLXMakeCurrent error.

This is caused by the same system GPU context being active in two
threads at the same time, which happens when the GPU context for the
compositor is created in the main thread, it is made current during
creation, but it is not reset to the main GPU context of the drawable
because it is null. So when the GPU compositor actually executes, it
makes the GPU context current again but in its own thread, causing a
BadAccess error in X11 and potentially other window systems.

So the root cause is that the drawable is nullptr, and an attempt to fix
this was committed in 0a70360eb6 but was reverted in 98722773da because
it caused serious issue that were not obvious.

This patch attempts another fix by simply releasing the system GPU
context created when calling the RE_system_gpu_context_ensure. This is
more robust anyways because callers do not expect the context to be
bound form an API point of view.

Omar Emara requested review from Clément Foucault 2024-11-04 13:34:44 +01:00

Clément Foucault approved these changes 2024-11-04 13:56:24 +01:00

Clément Foucault left a comment

Member

Looks much better indeed! Thanks!

Looks much better indeed! Thanks!

Omar Emara merged commit b9dbf2959d into main

2024-11-04 16:17:38 +01:00

Omar Emara referenced this issue from a commit

2024-11-04 16:17:39 +01:00

Fix: Crash with a BadAccess X_GLXMakeCurrent error

Omar Emara deleted branch release-render-context-on-ensure

2024-11-04 16:17:41 +01:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#129793

No description provided.