Fix: Overlay-Next: Images #130345

						
				@ -401,3 +401,3 @@

				    init_pass(background_ps_, draw_state);

				    draw_state = DRW_STATE_WRITE_COLOR | DRW_STATE_BLEND_ALPHA_UNDER_PREMUL;

				    draw_state = DRW_STATE_WRITE_COLOR | DRW_STATE_DEPTH_LESS | DRW_STATE_BLEND_ALPHA_UNDER_PREMUL;

Clément Foucault commented

2024-11-19 18:19:42 +01:00

Can you explain these states changes? As the original values are the ones from the legacy code. So I imagined that they would work?

Miguel Pozo commented

2024-11-19 18:29:47 +01:00

I'm not sure, maybe Legacy rendered the background on a separate texture?
But without this in Next the background images are rendered on top of the main render.

I'm not sure, maybe Legacy rendered the background on a separate texture? But without this in Next the background images are rendered on top of the main render. ![imagen](/attachments/4cde34d0-d793-4803-8428-7147575057c4)

imagen.png

997 KiB

overlay-camera-background.blend

526 KiB

Clément Foucault commented

2024-11-19 20:42:07 +01:00

Camera Background images used to be rendered on the default framebuffer, so not on the overlay framebuffer.

void OVERLAY_image_scene_background_draw(OVERLAY_Data *vedata)
{
  OVERLAY_PassList *psl = vedata->psl;

  if (DRW_state_is_fbo() && (!DRW_pass_is_empty(psl->image_background_scene_ps) ||
                             !DRW_pass_is_empty(psl->image_foreground_scene_ps)))
  {
    const DefaultFramebufferList *dfbl = DRW_viewport_framebuffer_list_get();
    GPU_framebuffer_bind(dfbl->default_fb);

    DRW_draw_pass(psl->image_background_scene_ps);
    DRW_draw_pass(psl->image_foreground_scene_ps);
  }
}

So in overlay next term, this correspond to resources.render(_in_front)_fb. Add a draw_on_render method to Cameras.

Camera Background images used to be rendered on the default framebuffer, so not on the overlay framebuffer. ``` void OVERLAY_image_scene_background_draw(OVERLAY_Data *vedata) { OVERLAY_PassList *psl = vedata->psl; if (DRW_state_is_fbo() && (!DRW_pass_is_empty(psl->image_background_scene_ps) || !DRW_pass_is_empty(psl->image_foreground_scene_ps))) { const DefaultFramebufferList *dfbl = DRW_viewport_framebuffer_list_get(); GPU_framebuffer_bind(dfbl->default_fb); DRW_draw_pass(psl->image_background_scene_ps); DRW_draw_pass(psl->image_foreground_scene_ps); } } ``` So in overlay next term, this correspond to `resources.render(_in_front)_fb`. Add a `draw_on_render` method to `Cameras`.

Clément Foucault commented

2024-11-19 20:45:23 +01:00

Also don't forget to group the draw_on_render together to avoid framebuffer switching.

Also don't forget to group the `draw_on_render` together to avoid framebuffer switching.

Miguel Pozo commented

2024-11-20 18:20:04 +01:00

It has been a bit confusing but I think I managed to mimic 100% the Legacy behavior.

"View as render" background images were rendered to the default framebuffer.
Non "View as render" background images were rendered to the overlay framebuffer.
Next Background cleared the overlay framebuffer as part of its pass. The clear had to be moved before the background image passes.
That DRW_STATE_DEPTH_GREATER did nothing in Legacy, it draws to a framebuffer without a depth attachment.

It has been a bit confusing but I think I managed to mimic 100% the Legacy behavior. "View as render" background images were rendered to the default framebuffer. Non "View as render" background images were rendered to the overlay framebuffer. Next Background cleared the overlay framebuffer as part of its pass. The clear had to be moved before the background image passes. That `DRW_STATE_DEPTH_GREATER` did nothing in Legacy, it draws to a framebuffer without a depth attachment.

fclem marked this conversation as resolved

source/blender/draw/engines/overlay/overlay_next_instance.cc Outdated

						
				@ -510,6 +510,7 @@ void Instance::draw(Manager &manager)

				  draw_layer_color_only(regular, resources.overlay_color_only_fb);

				  draw_layer_color_only(infront, resources.overlay_color_only_fb);

				  regular.empties.draw_in_front_images(resources.overlay_color_only_fb, manager, view);

Clément Foucault commented

2024-11-19 18:21:07 +01:00

If I remember, there is no regular because they are all in front. But I guess that makes sense to have both.

Miguel Pozo commented

2024-11-19 18:28:15 +01:00

Nope, that could be the case if we moved the In Front detection to Instance::object_is_in_front as I suggested in the chat.
Without this change, empties with OB_EMPTY_IMAGE_DEPTH_FRONT (that's the Depth setting in the Empty Data panel) but without "Object > Viewport Display > In Front" enabled won't be rendered.

Nope, that could be the case if we moved the In Front detection to `Instance::object_is_in_front` as I suggested in the chat. Without this change, empties with `OB_EMPTY_IMAGE_DEPTH_FRONT` (that's the Depth setting in the Empty Data panel) but without "Object > Viewport Display > In Front" enabled won't be rendered.

👍 1

fclem marked this conversation as resolved

Miguel Pozo added 3 commits 2024-11-20 18:06:20 +01:00

Merge branch 'main' into fix-overlay-images 4e63a7ee73

Mimic legacy behavior 029dd62f25

Remove unused DRW_STATE_DEPTH_GREATER ede4b5da20

The framebuffer doesn't has a depth attachment

Miguel Pozo added 1 commit 2024-11-20 18:10:31 +01:00

Cleanup b1727dcad5

Miguel Pozo added 1 commit 2024-11-20 18:25:45 +01:00

Reorder render passes 5f01a3cf86

Clément Foucault approved these changes 2024-11-20 18:50:22 +01:00

Miguel Pozo merged commit 03909f2691 into main

2024-11-20 19:05:40 +01:00

Miguel Pozo referenced this issue from a commit

2024-11-20 19:05:40 +01:00

Fix: Overlay-Next: Images

Miguel Pozo deleted branch fix-overlay-images

2024-11-20 19:05:43 +01:00

Sign in to join this conversation.

No reviewers

No Label

Development Management

Pipeline, Assets & IO

Interest

Platforms, Builds & Tests

Sculpt, Paint & Texture

Asset Browser Project

Legacy

Blender 2.8 Project

Legacy

Milestone 1: Basic, Local Asset Browser

Development Management

Pipeline, Assets & IO

Module

Platforms, Builds & Tests

Sculpt, Paint & Texture

Needs Info from Developers

Status

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on

#130336 Overlay-Next: Use submit_only

blender/blender

Reference: blender/blender#130345

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: Overlay-Next: Images #130345