Jorijn de Graaf bonj
  • Joined on 2023-02-10
Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-04-08 21:14:59 +02:00
981294301b Remove unused "id" uniform from shgrp_occlude
Jorijn de Graaf commented on pull request blender/blender#105498 2023-04-03 14:58:41 +02:00
DRW: Selection Occlusion

@Jeroen-Bakker reply to your review.

Draw manager should be as functionality agnostic as much as possible. Adding this if-statement might be ok as we also check if bone overlay is enabled.

Jorijn de Graaf commented on pull request blender/blender#106350 2023-04-02 23:11:53 +02:00
Fix #106247: Remove incorrect selection check when in multi-mesh

I don't think it's necessary to iterate over bases, so let's get rid of this:

  bool selected = false;
  LISTBASE_FOREACH (Base *, base, BKE_view_layer_object_bases_get(view_layer)) {
  
Jorijn de Graaf commented on pull request blender/blender#105498 2023-04-02 14:09:04 +02:00
DRW: Selection Occlusion

I'll keep an eye out what people say once it's merged with main, especially about the selection occlusion when set to 0.

It might be a good idea to make the selection occlusion optional, but…

Jorijn de Graaf commented on issue blender/blender#106352 2023-03-31 14:20:19 +02:00
Disabling selected face highlight disable color display of retopology overlay

@fclem says it perfectly. I don't use this feature, so I don't have a strong opinion on how it should work. Definitely a design issue rather than a bug.

Jorijn de Graaf commented on pull request blender/blender#106350 2023-03-31 02:41:28 +02:00
Fix #106247: Remove incorrect selection check when in multi-mesh

I have no jurisdiction to review but as the guy who opened the issue I want to say: this looks good to me 👍

Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-30 23:59:26 +02:00
2aed76c6b2 Merge branch 'main' into retopology-select
ed0e4f4043 UV: refactor uv packing, reduce usage of #BoxPack
cbb813886c Geometry Nodes: Simplify retrieval of node dependencies
76e0ca6b91 Build: suppress CMake warnings about newer Boost versions
40f050aadc UV: simplify packing usage of #BoxPack
Compare 51 commits »
Jorijn de Graaf commented on issue blender/blender#105461 2023-03-30 17:13:19 +02:00
Language names may be incorrect in the language menu

I'd say change Nederlandse taal to just Nederlands.

Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-29 22:45:08 +02:00
273c4c6991 Improve retopology overlay tooltip
Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-29 16:58:50 +02:00
24038c4938 Remove unnecessary RETOPOLOGY_OCCLUSION macro
f543885071 Use continue for depsgraph iterator
Compare 2 commits »
Jorijn de Graaf commented on pull request blender/blender#105498 2023-03-29 14:18:52 +02:00
DRW: Selection Occlusion

@JulienKaspar Thanks for your feedback!

The selection is also occluded if the retopology_offset is set to 0. That should maybe not be the case.

I don't see why not. The slider is just for…

Jorijn de Graaf commented on pull request blender/blender#105498 2023-03-29 02:35:39 +02:00
DRW: Selection Occlusion

@mano-wii Replying doesn't seem to work properly so I'll just comment here.

To your first comment about localized comments and grease pencil objects:

I was thinking of doing that too, but…

Jorijn de Graaf commented on pull request blender/blender#105498 2023-03-29 00:01:17 +02:00
DRW: Selection Occlusion

Re-requesting review from @mano-wii because I made several changes. They're all based on your feedback from the last review, and I don't expect you to find any problems, but just in case.

Jorijn de Graaf opened issue blender/blender#106247 2023-03-28 23:57:20 +02:00
Multi mesh edit mode select assert
Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-28 22:54:10 +02:00
be37244aba Merge branch 'main' into retopology-select
8d16e8f726 Merge branch 'blender-v3.5-release'
6e51f8d202 Fix Python Module build on Windows
ac0ed09735 Fix #104329 viewport render with path guiding crashes
a58c951c98 Merge branch 'blender-v3.5-release'
Compare 71 commits »
Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-28 22:50:21 +02:00
3336c1b45e Check both retopology and xray for selection occlusion
Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-28 21:43:09 +02:00
00cafbe04e Check if retopology is enabled for depsgraph iterator
Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-28 21:17:59 +02:00
a7a5f04530 Use retopology offset for selection depth group
Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-28 20:30:16 +02:00
3a85a0d907 Offset selection mesh towards view
Jorijn de Graaf pushed to retopology-select at bonj/blender 2023-03-28 18:22:19 +02:00
6424637919 Add comment explaining object type and mode checks