Denys Hsu cgtinker
0 Followers · 0 Following
  • Germany
  • Joined on 2023-02-21
Repositories
2
 Projects Public Activity Starred Repositories
2
Denys Hsu pushed to rotation_node at cgtinker/powership 2023-06-14 18:47:09 +02:00
f4cd44ae81 init
Denys Hsu commented on pull request dr.sybren/rignodes#4 2023-06-13 14:09:50 +02:00
Loop Nodes

Moving out the execution would definitely clean this up. I also considered to add an AbstractLoopNode because the _get_innern_loop_nodes method, _inputs and _outputs properties are not…

Denys Hsu commented on pull request dr.sybren/rignodes#4 2023-06-13 13:59:12 +02:00
Loop Nodes

Sorry, still stumbling.

Denys Hsu pushed to loop at cgtinker/powership 2023-06-13 13:48:31 +02:00
30fd4a91da small refactoring
Denys Hsu commented on pull request dr.sybren/rignodes#4 2023-06-13 13:39:02 +02:00
Loop Nodes

I agree but actually rewrote that part completely. It skipped nodes when there were looping nodes within the loops.

Denys Hsu commented on pull request dr.sybren/rignodes#4 2023-06-13 13:34:42 +02:00
Loop Nodes

Those properties are for the loop nodes. The idea has been to just "ignore the first socket" of the loop nodes by default so I can easily figure out what's the connected loop node have an easier…

Denys Hsu pushed to loop at cgtinker/powership 2023-06-13 13:18:24 +02:00
7d6e455518 fix looping nodes cycles in loops
Denys Hsu created pull request dr.sybren/rignodes#4 2023-06-12 16:39:11 +02:00
WIP: Loop Nodes
Denys Hsu created branch loop in cgtinker/powership 2023-06-12 15:44:34 +02:00
Denys Hsu pushed to loop at cgtinker/powership 2023-06-12 15:44:34 +02:00
764420af01 object node and refactoring
ce870e8f61 allow deep nesting
9eccd9d8aa init loop nodes
Compare 3 commits »
Denys Hsu pushed to main at cgtinker/powership 2023-06-11 20:10:50 +02:00
6e7ef9adb8 Rename PowerShip to RigNodes
27a1a0676c Update head rotation in powership_transfer.blend
d6475f44bc Hide typing error
8e11df212c Better functions for getting input socket values
47dced7d70 Reformat with black
Compare 11 commits »
Denys Hsu commented on pull request dr.sybren/rignodes#2 2023-06-05 15:05:11 +02:00
Fixed powership_transfer.blend

Interesting didn't receive the changes when pulling initially, thanks for updating it. LGTM, only the head rotation seems off (guess it should be Y up and Z track).

Denys Hsu closed pull request dr.sybren/rignodes#2 2023-06-05 15:05:11 +02:00
Fixed powership_transfer.blend
Denys Hsu created pull request dr.sybren/rignodes#2 2023-06-05 14:07:23 +02:00
Fixed powership_transfer.blend
Denys Hsu created branch transfer_blend in cgtinker/powership 2023-06-05 13:54:50 +02:00
Denys Hsu pushed to transfer_blend at cgtinker/powership 2023-06-05 13:54:50 +02:00
7889f4df26 recreated and relinked nodes
40895b697c fix powership_transfer.blend
d6475f44bc Hide typing error
8e11df212c Better functions for getting input socket values
47dced7d70 Reformat with black
Compare 9 commits »
Denys Hsu commented on pull request dr.sybren/rignodes#1 2023-06-05 11:17:35 +02:00
Motion transfer setup

I don't use those stubs, so mypy is arguably less useful in my setup, but I don't get any errors, at least not on the main branch. mypy.ini should be set up so that it ignores unknown…

Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-06-05 11:10:35 +02:00
3e91d1866b fix mypy error
Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-06-05 11:01:19 +02:00
cc09d703d2 hotfix: typing caused an issue
Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-06-05 10:46:48 +02:00
6f4850804a improve typing consistency