NLA tracks should not be editable when they contain library linked tracks.
I think that should be "... contain linked strips"?
yes, it should be, fixing that
Checking just…
I think it's worth noting that Blender is very inconsistent when it comes to how operators that need a selection behave when they don't have a selection:
- Symmetrize, Delete, Shade…
Decided to give selecting keyframes a try. While it feels good to have it within the handle selection and it seems a little out of place. Separating it would also seem wrong.
Besides decided to…
This is some nice functionality. I feel that there's one thing missing though: for all selected handles, select they keys, optionally deselecting the handles themselves. The addition of that…
Also, why use
shorthere at all? IMO it should just beenum eGraphKey_HandleSelect_Mode mode.
Yeah it should be eGraphKey_HandleSelect_Mode, will change that. Within the file all…
apart from the two minor things that I am unsure about it looks good to me i'll let sybren be the final judge
great, thanks for the review!
I think I copied an existing enum and modified it back then, there is no checking. In the 'C' scripts are lots of comments that don't follow this convention which is misleading, probably it would…