Denys Hsu cgtinker
  • Germany
  • Joined on 2023-02-21
Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-06-04 22:13:09 +02:00
65dece1627 RotateTowards default
Denys Hsu commented on pull request dr.sybren/rignodes#1 2023-06-04 22:10:03 +02:00
Motion transfer setup

Thanks for the hints and information! Good to know that generators are more efficient than list comprehensions. I always thought it's the other way around. Merged the changes from your main…

Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-06-04 22:00:01 +02:00
4d5ba27aa7 fix mypy typing err
Denys Hsu commented on pull request dr.sybren/rignodes#1 2023-06-04 21:38:30 +02:00
Motion transfer setup

Usually an angle is not signed, you got to define something to sign it. That's why I thought unsigned angles should be the default.

I rechecked and to be honest, I neither knew that the…

Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-06-04 21:32:14 +02:00
2c79d687f0 proper merge with main
Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-06-04 19:50:29 +02:00
a024f31128 pep257 and input socket refactoring
3aefbd183a rm ide specific gitignore files
636bd78dbf merge main
265fa2ca8e Document optional vs. regular sockets
dc5b59a6a0 Fix mypy errors
Compare 5 commits »
Denys Hsu commented on pull request dr.sybren/rignodes#1 2023-06-04 19:10:07 +02:00
Motion transfer setup

I think that can be removed. I was confused because the quaternion affected the scale which indicates that it's not a unit quaternion. This happened on longer bone chains - rounding the scale…

Denys Hsu commented on pull request dr.sybren/rignodes#1 2023-06-04 16:58:55 +02:00
Motion transfer setup

I thought it was like that in the python interface (and I was wrong). Just checked in mathutils_Vector.c, there the up axis is Y and the track axis is Z. Should we follow that…

Denys Hsu commented on pull request dr.sybren/rignodes#1 2023-05-26 20:07:55 +02:00
Motion transfer setup

Glad you like the patch.

I considered to remove the distance node just have a regular length node. On the one hand nodes like that are really easy to understand and kinda useful as they save…

Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-05-26 19:46:34 +02:00
0658fb153a fixed some whitespaces
Denys Hsu commented on pull request dr.sybren/rignodes#1 2023-05-26 19:39:25 +02:00
Motion transfer setup

That's why it hasn't been updating! My lsp destroyed the formatting a bit, doing my best to fix it – pylance has been fighting against mypy and no-one has been the winner I guess. Pep8 came to…

Denys Hsu commented on pull request dr.sybren/rignodes#1 2023-05-26 19:33:44 +02:00
Motion transfer setup

The length. I went through the comments and updated them (some were unrelated and happened due to closed eyes copy pasting...)

Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-05-26 19:30:19 +02:00
7ed7c3b608 corrected comments
7cbc8a8c40 rm formatting
b4b939c280 rm formatting changes, separate tree execution
Compare 3 commits »
Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-05-25 19:06:18 +02:00
8d349d9f57 checked demo and suz
Denys Hsu created pull request dr.sybren/rignodes#1 2023-05-24 21:47:41 +02:00
Motion transfer setup
Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-05-24 20:03:29 +02:00
ea8e0aede6 cleanup mathnodes
Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-05-24 19:49:12 +02:00
e27f71abec replace basic math nodes
fea3f043ed cleaning up math nodes
2079b82f30 math nodes and on frame changed update
6b5ef6d209 Allow muting nodes that are the inputs for other nodes
12727e156d Another wish
Compare 23 commits »
Denys Hsu pushed to main at cgtinker/powership 2023-05-24 19:42:49 +02:00
6b5ef6d209 Allow muting nodes that are the inputs for other nodes
12727e156d Another wish
6e6a474725 Add the new nodes to the documentation
c93db92bab Another example blend file, this one is even more WIP
27cd4ca57e More wishes
Compare 20 commits »
Denys Hsu created branch motion_transfer in cgtinker/powership 2023-05-24 10:14:31 +02:00
Denys Hsu pushed to motion_transfer at cgtinker/powership 2023-05-24 10:14:31 +02:00
7e5a8bcc22 math nodes and on frame changed update