Daiki Hashimoto daisea3e1203
0 Followers · 0 Following
  • Joined on 2023-11-25
Repositories
2
 Projects Public Activity Starred Repositories
Daiki Hashimoto created repository daisea3e1203/.profile 2023-12-21 17:36:23 +01:00
Daiki Hashimoto commented on pull request blender/blender#115807 2023-12-19 15:48:58 +01:00
Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode

@ChrisLend The changes requested by @dr.sybren has been addressed and were reviewed in the conversation thread, so this PR is probably ready to land!

I have also added a "Commit message for the…

Daiki Hashimoto commented on pull request blender/blender#115807 2023-12-19 15:33:56 +01:00
Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode

Thank you very much for the feedback!

Ideally, such cleanups would happen before this PR (first cleanup, then change functionality). In this case I don't think that would be worth the effort,…

0b0d45cb0c Format : remove redundant parentheses
Daiki Hashimoto commented on pull request blender/blender#115807 2023-12-12 14:32:14 +01:00
Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode

Thank you very much for the review and the insights about mesh data 🙏

The query is incorrect as you have pointed out, and have probably lead to the tools not functioning properly in some…

Daiki Hashimoto commented on pull request blender/blender#115807 2023-12-12 14:24:52 +01:00
Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode

@nathanvegdahl Thank you so much for pointing this out! This is probably related to the boolean check error @dr.sybren has pointed out, and should be fixed in the latest commit 🙏

93a58c7601 Refactor: clarify logic by separating the precondition check from the actual query
e11fce8298 Fix BKE_paint_select_bone_test to be clearer and to query for the correct flags
4b15675294 Merge branch 'main' into add-select-tools-to-bone-select-mode
48d35bfe53 Refactor: Pass Keyframe settings as arguments
f8b20936c8 Fix #115895: Surface drawing artifacts at borders
Compare 140 commits »
Daiki Hashimoto commented on pull request blender/blender#115807 2023-12-11 09:03:50 +01:00
Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode

@ChrisLend Do you think it would be beneficial to create a separate pull request for changing the behavior of clicking in an empty space during weight paint mode (row1 for LCS and RCS)? The…

Daiki Hashimoto commented on pull request blender/blender#115807 2023-12-08 14:58:13 +01:00
Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode

@Mets I checked the behavior of B and C hotkeys in weight paint mode, and they aligned with what you mentioned 👍 (region selecting with hotkeys doesn't deselect bones while region selecting…

Daiki Hashimoto commented on pull request blender/blender#115807 2023-12-08 14:28:10 +01:00
Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode

Thank you for spotting these mistakes! Will be careful with comments in future PRs 🙏

Daiki Hashimoto commented on pull request blender/blender#115807 2023-12-08 14:26:19 +01:00
Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode

I applied the same change to the two functions above (change the question mark to a period) since I encountered them many times when coding for this PR, and were used as it says.

05bb4f72e0 Clean comments: add period at end of comment sentence.
09a3f4b9b1 Clean comments: remove confusing question mark at end of comment.
Compare 2 commits »
Daiki Hashimoto commented on pull request blender/blender#115807 2023-12-08 13:40:23 +01:00
Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode

I forgot to mention in the description, but B and C hotkeys will be available with this patch! (the respective keymap from 3d View will be applied automatically now that the selection tools are…

Daiki Hashimoto commented on pull request blender/blender#115807 2023-12-08 12:20:00 +01:00
Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode

Thank you for the feedback! Will check the RCS behavior and append to the PR description.

Daiki Hashimoto created pull request blender/blender#115807 2023-12-05 16:04:47 +01:00
WIP: Add box, circle and lasso selection tools to weight paint + bone select mode
Daiki Hashimoto created branch add-select-tools-to-bone-select-mode in daisea3e1203/blender 2023-12-05 09:22:53 +01:00
c6dfd6c199 Stay in bone select mode while using select tools when there are multiple armature modifiers
4702be37eb Pick bones using box, circle and lasso select
fa0ce9f374 Handle select operators in bone select mode if pose mode armature exists
fb7a32b4a9 Add function to test if the given object is in weight paint mode AND bone select mode
9a14bc7c6b In weight paint mode, add box, circle and lasso select tools to bone select mode
Compare 10 commits »
Daiki Hashimoto deleted branch add_bone_selection_switch from daisea3e1203/blender 2023-12-02 09:18:10 +01:00
Daiki Hashimoto commented on pull request blender/blender#115409 2023-11-29 04:02:37 +01:00
Fix #44834: Add bone selection icon next to face and vertex selection in weight paint mode

@ChrisLend Thank you so much for the review!

And the order of the items in the toolbar should be consistent between vert/face/bone select modes.

This should be addressed in the last…

Daiki Hashimoto pushed to add_bone_selection_switch at daisea3e1203/blender 2023-11-29 03:53:26 +01:00
6edded7564 Align the order of toolbar items between vert/face/bone select modes
698b4960f1 Merge branch 'main' into add_bone_selection_switch
09caf59690 Fix #115298: Sculpt mask removed with undo involving mode change
c083b3b8d2 Cleanup: Remove outdated normals comment for mesh validation
19b9b8d431 Cleanup: Move mesh looptri real edges function
Compare 94 commits »