Remove Redundant Pies #4

Demeter Dzadik · 2024-08-17T12:10:13+02:00

Demeter Dzadik commented

2024-08-17 12:10:13 +02:00

This PR removes two pie menus: Object Modes, and Shading Pie. These were originally implemented in the add-on before they were implemented in core Blender.

Reasons for removal

Mode Pie

As new modes and object types get added to Blender (like particle hair and grease pencil v3), this needs to be maintained, and once I move on to other projects, the add-on is going to become unmaintained again. The old pie menu was omitting Grease Pencil Vertex Paint, and all particle edit modes, even though they've been in Blender for about a year now.
Having two features that do the same things is confusing for new users. Tab is one object mode pie menu with a certain layout, and Ctrl+Tab is another object mode pie menu with a completely different layout.
It's not intuitive what the Object/Edit toggle operator will do when you're in any other mode, like Sculpt mode. Will it enter Object or Edit mode?
I think the Vertex/Edge/Face select drop-down is super slow and there's no reason to use it when you can just go into Edit mode and press 1, 2, 3. It's 2 actions but it's still faster than the drop-down.

Shading Pie

Has the same or fewer options as the built-in Shading Pie except:
Shade Smooth/Flat feels dangerous to have here, because it's not made clear to the user that these are destructive object-data-modifying operations, whereas all other buttons here are just temporary viewport settings. In the future, I'd like to add a new Object Display pie menu, where I think these will be a better fit.

This PR removes two pie menus: Object Modes, and Shading Pie. These were originally implemented in the add-on before they were implemented in core Blender. # Reasons for removal #### Mode Pie <img src="/attachments/3e2731da-ad1f-4fad-8f1d-e6a3b4bd605a" width=500> - As new modes and object types get added to Blender (like particle hair and grease pencil v3), this needs to be maintained, and once I move on to other projects, the add-on is going to become unmaintained again. The old pie menu was omitting Grease Pencil Vertex Paint, and all particle edit modes, even though they've been in Blender for about a year now. - Having two features that do the same things is confusing for new users. Tab is one object mode pie menu with a certain layout, and Ctrl+Tab is another object mode pie menu with a completely different layout. - It's not intuitive what the Object/Edit toggle operator will do when you're in any other mode, like Sculpt mode. Will it enter Object or Edit mode? - I think the Vertex/Edge/Face select drop-down is super slow and there's no reason to use it when you can just go into Edit mode and press 1, 2, 3. It's 2 actions but it's still faster than the drop-down. #### Shading Pie <img src="/attachments/d8b38ce4-648b-499d-a5ba-bcc5c6e15027" width=500> - Has the same or fewer options as the built-in Shading Pie except: - Shade Smooth/Flat feels dangerous to have here, because it's not made clear to the user that these are destructive object-data-modifying operations, whereas all other buttons here are just temporary viewport settings. In the future, I'd like to add a new Object Display pie menu, where I think these will be a better fit.

image.png

110 KiB

image.png

88 KiB

Demeter Dzadik added 3 commits 2024-08-17 12:10:14 +02:00

Refactor Proportional Editing Pie 1c48ab2622

No functional changes intended (that will come in next commit),
but it turns out we were summoning the wrong pie menu in
edit mode, so, that's fixed.

Proportional Pie: Reorganize layout 7340c9c347

Remove Object & Shading Pies ba75490ecd

Demeter Dzadik force-pushed remove_redundant_pies from ba75490ecd to 9bfa41645b

2024-08-17 12:14:59 +02:00

Compare

Demeter Dzadik added 1 commit 2024-08-17 12:16:20 +02:00

Update ReadMe 45909f5ba0

Demeter Dzadik merged commit 63c3eefeb1 into main

2024-08-21 02:30:46 +02:00

Demeter Dzadik deleted branch remove_redundant_pies

2024-08-21 02:30:46 +02:00

Demeter Dzadik referenced this issue from a commit

2024-08-21 02:30:46 +02:00

Merge pull request 'Remove Redundant Pies' (#4) from remove_redundant_pies into main

Markus commented

2024-08-25 11:57:49 +02:00

First-time contributor

@Mets I did use the shading pie menu a lot as there appear to be neither pie menu nor shortcuts for switching viewport shading when using Blender with the "Industry compatible" keymap. Therefore pressing z is already drilled into my head and I was quite surprised to suddenly find it not working anymore today. So any chance of not removing this useful menu?

I do agree with you though that "Shade Smooth" and "Shade Flat" did not fit well into the menu.

@Mets I did use the shading pie menu _a lot_ as there appear to be neither pie menu nor shortcuts for switching viewport shading when using Blender with the "Industry compatible" keymap. Therefore pressing z is already drilled into my head and I was quite surprised to suddenly find it not working anymore today. So any chance of not removing this useful menu? I do agree with you though that "Shade Smooth" and "Shade Flat" did not fit well into the menu.

Demeter Dzadik commented

2024-08-27 21:06:11 +02:00

Thanks for the feedback! I didn't realize the alternate keymaps didn't have these pies. I find that super strange, actually.

What I think I will do (soon), is register hotkeys to the native pie menus when using those alternate keymaps.

Thanks for the feedback! I didn't realize the alternate keymaps didn't have these pies. I find that super strange, actually. What I think I will do (soon), is register hotkeys to the native pie menus when using those alternate keymaps.

Sign in to join this conversation.

No reviewers