Clément Foucault fclem
  • I'm pixel pusher.

  • Joined on 2014-07-09
Clément Foucault commented on pull request blender/blender#108398 2023-06-27 17:45:09 +02:00
EEVEE Next: Ambient Occlusion

Do you want to always enable it for the main shading too? Kind of. If it has to be an option it would be elsewhere.

Clément Foucault commented on pull request blender/blender#108398 2023-06-27 17:26:31 +02:00
EEVEE Next: Ambient Occlusion

Also the F12 Ambient Occlusion render pass doesn't work. It doesn't show in the render passes.

Clément Foucault suggested changes for blender/blender#108398 2023-06-27 17:03:17 +02:00
EEVEE Next: Ambient Occlusion

The AO lib depends on the raytracing lib, which depends on its own buffer parameters.

Clément Foucault commented on pull request blender/blender#108398 2023-06-27 17:03:17 +02:00
EEVEE Next: Ambient Occlusion

Do not bind other resources here. Will result in double binds and it is against the design of this function.

Clément Foucault commented on pull request blender/blender#108398 2023-06-27 17:03:16 +02:00
EEVEE Next: Ambient Occlusion

Just remove the code. Dead code lying around is not good.

Clément Foucault pushed to main at blender/blender 2023-06-27 16:46:27 +02:00
fde8e6ce65 Fix #109406: Ignore unsupported socket in shader
Clément Foucault closed issue blender/blender#109406 2023-06-27 16:46:27 +02:00
Regression: Crash in GPU_material_from_nodetree
Clément Foucault merged pull request blender/blender#109410 2023-06-27 16:46:25 +02:00
Fix #109406: Ignore unsupported socket in shader
Clément Foucault created pull request blender/blender#109390 2023-06-26 22:50:57 +02:00
GHOST: Bump OpenGL minimmum version to 4.3
Clément Foucault pushed to ghost-opengl-4.3 at fclem/blender 2023-06-26 22:50:01 +02:00
6b39fbcf28 GHOST: Bump OpenGL minimmum version to 4.3
bef20cd3f1 Curves: Share positions array for single point profile at origin
6bccea2ceb Cleanup: Remove unused variable in a add node search function
49977c3aee Cleanup: Remove unused variable in curve to mesh conversion
48fad9cd0c Curves: Optimize curve to mesh with single point profile
Compare 10 commits »
Clément Foucault created branch ghost-opengl-4.3 in fclem/blender 2023-06-26 22:50:01 +02:00
Clément Foucault pushed to main at blender/blender 2023-06-26 19:36:17 +02:00
4038cabc6d EEVEE: Remove unneeded GPU_finish
Clément Foucault merged pull request blender/blender#109382 2023-06-26 19:36:16 +02:00
EEVEE: Remove unneeded GPU_finish
Clément Foucault commented on pull request blender/blender#109382 2023-06-26 19:27:06 +02:00
EEVEE: Remove unneeded GPU_finish

Nvidia's implementation between Linux and Windows is consistent most of the time. So I prefer to be safe here. Also this path is hopefully going to become irrelevant with eevee-next.

Clément Foucault suggested changes for blender/blender#109382 2023-06-26 18:05:23 +02:00
EEVEE: Remove unneeded GPU_finish

I would prefer just making this wrokaround Nvidia only in this case. Use GPU_type_matches_ex(GPU_DEVICE_NVIDIA, GPU_OS_ANY, GPU_DRIVER_ANY, GPU_BACKEND_OPENGL)

Clément Foucault commented on issue blender/blender#109040 2023-06-26 11:22:39 +02:00
Overlay: Edit Mesh wireframe incorrect bias

That might have to do with the new retopology Z-bias that fails when one of the vertex is behind the nearplane or the camera origin.

CC @bonj