Clément Foucault fclem
29 Followers · 0 Following

  • I'm pixel pusher.

  • Joined on 2014-07-09
Repositories
3
 Projects Public Activity Starred Repositories
Clément Foucault commented on pull request blender/blender#108639 2023-06-22 12:01:44 +02:00
EEVEE-Next: Irradiance Cache: Initial Implementation

I will use world as it fits better the terminology used in the rest of EEVEE-Next.

Clément Foucault pushed to eevee-next-soft-shadows at fclem/blender 2023-06-22 00:43:09 +02:00
ff906ac974 Fix wrong sampling dimension
Clément Foucault created branch eevee-next-soft-shadows in fclem/blender 2023-06-22 00:37:55 +02:00
Clément Foucault pushed to eevee-next-soft-shadows at fclem/blender 2023-06-22 00:37:55 +02:00
fe6f17e833 EEVE-Next: Shadow Map Tracing: Initial commit
b779c6ebe1 Merge branch 'blender-v3.6-release'
bca236bfa0 I18n: Updated translations from svn trunk (r6585).
2264a32f54 Fix: Missing select menu for GPv3
bb041b3f48 Fix #109207: Can't select in gpencil edit mode
Compare 10 commits »
Clément Foucault commented on pull request blender/blender#108639 2023-06-21 17:58:57 +02:00
EEVEE-Next: Irradiance Cache: Initial Implementation

The main issue seems to be solved for NVidia and MacOS.

However, on Metal backend, there are remaining warnings that I think should be tackled as separate issue.

WARN (gpu.debug.metal):…
Clément Foucault pushed to eevee-next-irradiance-cache at fclem/blender 2023-06-21 13:37:55 +02:00
4c294146bc Merge branch 'main' into eevee-next-irradiance-cache
28799a20e3 Merge branch 'blender-v3.6-release'
1347640e38 Sculpt: Fix #109112: Connected island code broken for multires
93020db5e0 Sculpt: Fix #109112: Connected island code broken for multires
ec18e11c37 Cleanup: remove unnecessary "for_write" in method name
Compare 374 commits »
Clément Foucault opened issue blender/blender#109202 2023-06-21 13:24:52 +02:00
GPU Module Development Quirks
Clément Foucault pushed to eevee-next-irradiance-cache at fclem/blender 2023-06-21 12:48:41 +02:00
29a9e55cf8 EEVEE-Next: Fix wrong image format
Clément Foucault approved blender/blender#109153 2023-06-20 14:10:34 +02:00
Fix wrong conversion from power to radiance of area lights
Clément Foucault commented on pull request blender/blender#108506 2023-06-19 20:26:07 +02:00
Cycles/EEVEE: change point light to double-sided sphere light

This sin -> tan is a bit cryptic. It could help if it was a full sentence.

Clément Foucault approved blender/blender#108506 2023-06-19 20:23:08 +02:00
Cycles/EEVEE: change point light to double-sided sphere light
Clément Foucault commented on pull request blender/blender#108398 2023-06-16 17:08:36 +02:00
EEVEE Next: Ambient Occlusion

Why is this needed?

Clément Foucault suggested changes for blender/blender#108398 2023-06-16 17:07:00 +02:00
EEVEE Next: Ambient Occlusion
  • Rename all _ao_ files to ambient_occlusion.
Clément Foucault commented on pull request blender/blender#108398 2023-06-16 17:07:00 +02:00
EEVEE Next: Ambient Occlusion

Do not use AO as abreviation in either typenames or members name.

Clément Foucault commented on pull request blender/blender#108398 2023-06-16 17:06:59 +02:00
EEVEE Next: Ambient Occlusion

Prefer a function that returns an empty occlusion data.

Clément Foucault commented on pull request blender/blender#108398 2023-06-16 17:06:59 +02:00
EEVEE Next: Ambient Occlusion

Remove these and prefer individual member assignment.

Clément Foucault commented on pull request blender/blender#108398 2023-06-16 17:06:58 +02:00
EEVEE Next: Ambient Occlusion

Declare the constant before this line and add a comment that this fixes a NaN issue on some Intel GPU (add link to original issue).

Clément Foucault commented on pull request blender/blender#108398 2023-06-16 17:06:58 +02:00
EEVEE Next: Ambient Occlusion

It is unclear what this TODO is referring to: a specific function, or the whole file?

Clément Foucault commented on pull request blender/blender#108398 2023-06-16 17:06:58 +02:00
EEVEE Next: Ambient Occlusion

no abreviation here too MAT_AMBIENT_OCCLUSION

Clément Foucault commented on pull request blender/blender#108398 2023-06-16 17:06:57 +02:00
EEVEE Next: Ambient Occlusion

I'm almost tempted to remove this pass altogether. It might just become a subpass of the raytracing pipeline.