Clément Foucault fclem
29 Followers · 0 Following

  • I'm pixel pusher.

  • Joined on 2014-07-09
Repositories
3
 Projects Public Activity Starred Repositories
Clément Foucault commented on pull request blender/blender#108757 2023-06-08 16:53:51 +02:00
Metal: Resolve issues with buffer reading and clearing

I see. Well, it is always a welcome addition for debugability. So, I would say, let it in.

Clément Foucault commented on pull request blender/blender#108757 2023-06-08 16:52:26 +02:00
Metal: Resolve issues with buffer reading and clearing

Perhaps for simplicity, this path should only be used for clear to zero? I don't think there is any problem with checking the 4 bytes. It will work for 0xFFFFFFFF and 0x00000000 cases which…

Clément Foucault pushed to main at blender/blender 2023-06-08 16:49:48 +02:00
2e8317873f Metal: DrawManager-Next: Fix Object bounds and infos
Clément Foucault merged pull request blender/blender#108766 2023-06-08 16:49:47 +02:00
Metal: DrawManagerNext Object bounds and info fixes
Clément Foucault approved blender/blender#108766 2023-06-08 16:48:58 +02:00
Metal: DrawManagerNext Object bounds and info fixes
Clément Foucault pushed to main at blender/blender 2023-06-08 16:47:51 +02:00
72987941e7 Metal: EEVEE-Next: Fix light and shadow OOB issues
Clément Foucault merged pull request blender/blender#108768 2023-06-08 16:47:50 +02:00
Metal: EEVEE Next light and shadow OOB issues
Clément Foucault approved blender/blender#108768 2023-06-08 16:47:14 +02:00
Metal: EEVEE Next light and shadow OOB issues
Clément Foucault commented on pull request blender/blender#108757 2023-06-08 16:39:35 +02:00
Metal: Resolve issues with buffer reading and clearing

Should we even allow this case? if usage is GPU_USAGE_DEVICE_ONLY, I would suspect result is never read back.

Clément Foucault suggested changes for blender/blender#108757 2023-06-08 16:39:35 +02:00
Metal: Resolve issues with buffer reading and clearing
Clément Foucault commented on pull request blender/blender#108757 2023-06-08 16:39:34 +02:00
Metal: Resolve issues with buffer reading and clearing

I'm not sure this is correct. You should check if the bit pattern is 8bit. So the check should be:

Clément Foucault approved blender/blender#108718 2023-06-08 12:37:29 +02:00
Realtime Compositor: Implement Sun Beams node
Clément Foucault commented on pull request blender/blender#108723 2023-06-08 09:01:43 +02:00
Cleanup: renaming of GPU contexts for clarity

same

Clément Foucault approved blender/blender#108723 2023-06-08 09:01:43 +02:00
Cleanup: renaming of GPU contexts for clarity

I don't know if the scope of this patch is to be more thorough or not.

Clément Foucault commented on pull request blender/blender#108723 2023-06-08 09:01:43 +02:00
Cleanup: renaming of GPU contexts for clarity

same

Clément Foucault commented on pull request blender/blender#108723 2023-06-08 09:01:42 +02:00
Cleanup: renaming of GPU contexts for clarity

Still mention of OpenGL, maybe mention other backend as well? or just "GPU backend".

Clément Foucault commented on pull request blender/blender#108723 2023-06-08 09:01:42 +02:00
Cleanup: renaming of GPU contexts for clarity

Fix comments in this file.

Clément Foucault commented on pull request blender/blender#108723 2023-06-08 09:01:42 +02:00
Cleanup: renaming of GPU contexts for clarity

Fix comments in this file. Rename OpenGL Context to System Context.

Clément Foucault commented on pull request blender/blender#108723 2023-06-08 09:01:41 +02:00
Cleanup: renaming of GPU contexts for clarity

I think it's a good opportunity to also rename this.

Clément Foucault commented on pull request blender/blender#108723 2023-06-08 09:01:41 +02:00
Cleanup: renaming of GPU contexts for clarity

Missed occurence.