The patch looks good. I would still recommend to split the enum renaming to main first. But that's a bit nitpicky in my opinion. So do what you think is best.
Not sure if these readability changes should be included in this patch. Commit them directly to main first.
This looks good! Just need to cleanup the unused line and it's good to be merged.
could you explain why this wouldn't work on other platforms
The function call GPU_line_smooth(true); enables a deprecated OpenGL feature that isn't available on Metal. We have a software…
This isn't a portable fix. It will not work on MacOS / Metal backend.
@OmarEmaraDev My bad. If DrawDataList is only to used for its recalc flag, then it is ok to use. This usage could be easily refactored. The "bad" usage starts when we are storing engine…
Is there a reason to use DrawDataList (itself quite bad) instead of just storing one of multiple GPUTextures inside the Texture ID runtime?
Why? In the future, we could have surface shaders evaluate the volume properties.
This comment maybe introduce confusion. This could be confused with the actual integration which is another shader. This is the equivalent to the resolve step.