Clément Foucault fclem
  • I'm pixel pusher.

  • Joined on 2014-07-09
Clément Foucault suggested changes for blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

I think the debug code is confusing and not isolated. Might be better to remove it. We don't need that in production (I mean the cost of having a separate framebuffer + clear etc...), you can just use an empty framebuffer for that.

Clément Foucault commented on pull request blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

Use exp2 instead of pow(2, x). Try to apply this everywhere.

Clément Foucault commented on pull request blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

Be conservative in Z too. Bias far_box_t by step_size to have one more iteration before and after.

Clément Foucault commented on pull request blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

Im' not sure why you are changing that for the debug visuals.

Clément Foucault commented on pull request blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

I think we need a fullpixel here.

Clément Foucault commented on pull request blender/blender#104580 2023-02-14 01:07:20 +01:00
EEVEE Next: Tag shadowmap usage for transparent object volumes

This only works because max_v2 is a define. Use vs_inflate_vector.xy to avoid the confusion.

Clément Foucault commented on pull request blender/blender#104687 2023-02-13 23:22:10 +01:00
Metal: Resolve race condition when releasing large numbers of buffers simultaneously.

I didn't catch that first but has_next_pool_ is basically the list length. Might be worth renaming the variable.

Clément Foucault commented on pull request blender/blender#104687 2023-02-13 23:22:10 +01:00
Metal: Resolve race condition when releasing large numbers of buffers simultaneously.

I have to admit I'm a bit doubtful about what's the intent here. Is the lock thing inside the loop supposed to just slow down the waiting thread and avoid high CPU usage? This does feel hacky anyway.

Clément Foucault commented on pull request blender/blender#104536 2023-02-13 22:02:33 +01:00
Eevee: GPU Material node graph optimization.

As a side note, I think the patch is in mergeable state, that's why I approved it. But would like to see the small fixes be done first.

Clément Foucault commented on pull request blender/blender#104536 2023-02-13 22:01:38 +01:00
Eevee: GPU Material node graph optimization.

Document this function.

Clément Foucault commented on pull request blender/blender#104536 2023-02-13 22:01:38 +01:00
Eevee: GPU Material node graph optimization.

How does that work? Material can have different resources based on their flag (see EEVEE_material_bind_resources(à). Unless this is only for the vertex inputs and fragment outputs, these should be the same.

Clément Foucault commented on pull request blender/blender#104536 2023-02-13 22:01:38 +01:00
Eevee: GPU Material node graph optimization.

Maybe note what is the expected status of both parameters. I guess material can be in any state, whereas default_material should be compiled?

Clément Foucault approved blender/blender#104536 2023-02-13 22:01:38 +01:00
Eevee: GPU Material node graph optimization.

I think the patch is clear and usage is all good.

Clément Foucault pushed to main at blender/blender 2023-02-13 18:16:54 +01:00
c2a5c592fe Fix #103397: Vector UI control shader UBO alignment fix.
Clément Foucault closed issue blender/blender#103397 2023-02-13 18:16:54 +01:00
MacOS Metal GPU backend: Vector UI control not visible
Clément Foucault merged pull request blender/blender#104699 2023-02-13 18:16:52 +01:00
Fix T103397: Vector UI control shader UBO alignment fix.
Clément Foucault pushed to Fix_T103397_v3 at Jason-Fielder/blender 2023-02-13 18:10:50 +01:00
311b62e0ea Merge branch 'main' into Fix_T103397_v3
0e1a6f6033 Cleanup: Add in NLAStrip / NLATrack remove / clean methods
d42c803f5b Cleanup: add comment explaining #interpf is performing lerp
218a909dec GPencil: Fix unreported Eyedropper color difference in Materials
bea1eff3a5 Fix: No update setting curve selection domain with all selected
Compare 6 commits »