Falk David filedescriptor

9 Followers · 0 Following

• Grease Pencil developer at Blender.

• Joined on 2017-01-04
• • 

Overview Repositories

7

Projects Public Activity Starred Repositories

1

Falk David suggested changes for blender/blender#129936 2024-11-07 11:50:58 +01:00

Fix #129873: GPv3: Missing material name overlay

Falk David commented on pull request blender/blender#129936 2024-11-07 11:50:56 +01:00

Fix #129873: GPv3: Missing material name overlay

Would be good to initialize these.

Falk David commented on pull request blender/blender#129936 2024-11-07 11:50:55 +01:00

Fix #129873: GPv3: Missing material name overlay

Should we handle multi-frame for this overlay? Does 4.2 show material names for all frames or just the current one?

Falk David commented on pull request blender/blender#129936 2024-11-07 11:50:54 +01:00

Fix #129873: GPv3: Missing material name overlay

I'm not sure I understand this comment. The functions like retrieve_visible_drawings should replace BKE_gpencil_visible_stroke_advanced_iter.

Falk David commented on pull request blender/blender#129944 2024-11-07 11:48:42 +01:00

Fix: GPv3: "Only In Multiframe" overlay not working

I see, would it work if we pass onion_skining (DRW_context_state_get()->v3d->gp_flag) value to retrieve_visible_drawingsingrease_pencil_geom_batch_ensure`? 👀

Like I said, if you have…

Falk David commented on pull request blender/blender#129944 2024-11-07 11:47:15 +01:00

Fix: GPv3: "Only In Multiframe" overlay not working

Falk David suggested changes for blender/blender#129944 2024-11-07 11:44:20 +01:00

Fix: GPv3: "Only In Multiframe" overlay not working

This doesn't fix the issue unfortunately.

Falk David commented on pull request blender/blender#129944 2024-11-07 11:44:19 +01:00

Fix: GPv3: "Only In Multiframe" overlay not working

The comment explains why this is set to always true.

Falk David suggested changes for blender/blender#129890 2024-11-07 11:38:37 +01:00

Fix: GPv3: Vertex group functions edit all keyframes

Some cleanup comments.

Falk David commented on pull request blender/blender#129890 2024-11-07 11:38:36 +01:00

Fix: GPv3: Vertex group functions edit all keyframes

all_drawings

Falk David commented on pull request blender/blender#129890 2024-11-07 11:38:35 +01:00

Fix: GPv3: Vertex group functions edit all keyframes

Use a mutable reference :

Falk David commented on pull request blender/blender#129890 2024-11-07 11:38:33 +01:00

Fix: GPv3: Vertex group functions edit all keyframes

all_drawing -> all_drawings

Falk David suggested changes for blender/blender#128080 2024-11-07 11:29:46 +01:00

Fix #125230: Issues when loading file with pinning gpencil brush material

Would be good if we can rebase this for 4.3!

Falk David commented on pull request blender/blender#122813 2024-11-07 11:27:27 +01:00

Fix #121233: GPv3: Primitives: Add missing confirm action and ability to pan view-port.

@blender-bot build

Falk David commented on pull request blender/blender#129878 2024-11-07 11:19:19 +01:00

Fix #124725: GPv3: Masked layers not rendered correctly with onion skinning

@blender-bot build

Falk David pushed to fix-124725 at filedescriptor/blender 2024-11-07 11:18:52 +01:00

bb15a72ad1 Cleanup grease_pencil_layer_cache_get

b6115deace Merge branch 'blender-v4.3-release' into fix-124725

831166b4dc Fix #129907: Grease Pencil brush size gets stuck at 0

30ba6bfa7e Cleanup: Unused function argument

f3342fa680 Fix #129708: Vulkan: Add limit checks when creating images

Compare 48 commits »

Falk David commented on pull request blender/blender#129937 2024-11-07 10:51:32 +01:00

Fix #129907: Grease Pencil brush size gets stuck at 0

@PratikPB2123 Done!

Falk David pushed to blender-v4.3-release at blender/blender 2024-11-07 10:51:22 +01:00

831166b4dc Fix #129907: Grease Pencil brush size gets stuck at 0

Falk David commented on pull request blender/blender#129937 2024-11-07 10:49:56 +01:00

Fix #129907: Grease Pencil brush size gets stuck at 0

Will do, thanks for noticing!

Falk David approved blender/blender#129790 2024-11-07 10:42:00 +01:00

Fix #129749: Use consistent GPv3 color settings in different modes