infrastructure/blender-buildbot-www
1
0
Fork 2
Code Issues 4 Pull Requests 1 Projects Releases Wiki Activity

UI: Hide stable builds #5

Merged
Pablo Vazquez merged 2 commits from pablovazquez/blender-buildbot-www:ui-hide-stable-builds into develop 2024-06-27 19:41:34 +02:00
Conversation 2 Commits 2 Files Changed 1 +4 -10
Pablo Vazquez commented 2024-06-27 17:02:55 +02:00
Owner
Copy Link

They were exposed mainly so release maintainers could keep an eye on
them. This is no longer necessary since we have an API for it at:
/?format=json&v=1
e.g. https://builder.blender.org/download/daily/?format=json&v=1

Hide these in all environments (LOCAL, UATEST, and PROD).

Before After
Before After
They were exposed mainly so release maintainers could keep an eye on them. This is no longer necessary since we have an API for it at: `/?format=json&v=1` e.g. https://builder.blender.org/download/daily/?format=json&v=1 Hide these in all environments (LOCAL, UATEST, and PROD). |Before|After| |----|----| ![Before](/attachments/416857db-6ede-44b7-8d93-2e8e30673cb6)|![After](/attachments/7daa97b5-9616-4bcf-b6fd-03d8a52bfa0c)|
image.png
318 KiB
image.png
224 KiB
Pablo Vazquez added 1 commit 2024-06-27 17:02:56 +02:00 
They were exposed mainly so release maintainers could keep an eye on
them. This is no longer necessary since we have an API for it at:
`/?format=json&v=1`
e.g. https://builder.blender.org/download/daily/?format=json&v=1

Hide these in all environments (LOCAL, UATEST, and PROD).
Pablo Vazquez changed target branch from master to develop 2024-06-27 18:58:10 +02:00
Pablo Vazquez added 1 commit 2024-06-27 19:03:13 +02:00
Sergey Sharybin requested review from Sergey Sharybin 2024-06-27 19:23:09 +02:00
Sergey Sharybin requested changes 2024-06-27 19:24:07 +02:00
Dismissed
Sergey Sharybin left a comment
Owner
Copy Link

Hiding Stable releases is something that is coming up every now and then. The downside of this is that it is harder to grab the build without going to some deeper depths of the system. It might be OK, but is something for Thomas or Phillipp to sign off on.

The side effect of that would be that right after a release, the Blender version will disappear from the list. I am not sure if that is really that more clear.

The Release Candidate is not to be hidden. That effectively makes it impossible to test blender at bcon4, and makes it impossible for people to test builds after some commits are landed as part of LTS, before the LTS has been released.

Hiding Stable releases is something that is coming up every now and then. The downside of this is that it is harder to grab the build without going to some deeper depths of the system. It might be OK, but is something for Thomas or Phillipp to sign off on. The side effect of that would be that right after a release, the Blender version will disappear from the list. I am not sure if that is really that more clear. The Release Candidate is not to be hidden. That effectively makes it impossible to test blender at bcon4, and makes it impossible for people to test builds after some commits are landed as part of LTS, before the LTS has been released.
Thomas Dinges commented 2024-06-27 19:27:07 +02:00
First-time contributor
Copy Link

Hiding stable and going via the API / JSON is fine for me.

The Release Candidates should be kept, but they are still on the screenshot so I assume that was a mistake in the title.

Hiding stable and going via the API / JSON is fine for me. The Release Candidates should be kept, but they are still on the screenshot so I assume that was a mistake in the title.
Pablo Vazquez changed title from UI: Hide stable and release candidate builds to UI: Hide stable and builds 2024-06-27 19:29:55 +02:00
Pablo Vazquez changed title from UI: Hide stable and builds to UI: Hide stable builds 2024-06-27 19:30:01 +02:00
Sergey Sharybin approved these changes 2024-06-27 19:30:18 +02:00
Sergey Sharybin left a comment
Owner
Copy Link

They are not hiding now, Pablo updated the patch as i was typing I think.
From the code side it seems fine to me!

They are not hiding now, Pablo updated the patch as i was typing I think. From the code side it seems fine to me!
❤️ 1
Pablo Vazquez commented 2024-06-27 19:32:00 +02:00
Author
Owner
Copy Link

Yes, my bad. Initially I hid them but then realised how silly that was and fixed the code but forgot to update the title.

Yes, my bad. Initially I hid them but then realised how silly that was and fixed the code but forgot to update the title.
Pablo Vazquez merged commit 8c89920f33 into develop 2024-06-27 19:41:34 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Sergey Sharybin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-buildbot-www#5
No description provided.
Delete Branch "pablovazquez/blender-buildbot-www:ui-hide-stable-builds"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?