infrastructure/conference-website
1
1
Fork 1
Code Issues 14 Pull Requests Releases Activity

UI: Implement toggle-bars to My conference filters #103981

Merged
Márton Lente merged 5 commits from ui/my-conference-toggles into main 2024-10-29 15:20:31 +01:00
Conversation 2 Commits 5 Files Changed 3 +32 -18
Márton Lente commented 2024-10-22 18:36:03 +02:00
Owner
Copy Link

This pull-request changes My conference filter buttons to Web Assets v2 style toggle-bars for Going and Favorited items.

Screenshot:

ui-my-conference-toggles.png
ui-my-conference-toggles-dark.png

This pull-request changes _My conference_ filter buttons to Web Assets v2 style toggle-bars for _Going_ and _Favorited items._ *Screenshot:* ![ui-my-conference-toggles.png](/attachments/13ea7e9e-f2ec-40de-8f7a-54e647358356) ![ui-my-conference-toggles-dark.png](/attachments/3d6950ab-b31a-4cc1-9d9f-c854fb772a72)
ui-my-conference-toggles.png
4.9 KiB
ui-my-conference-toggles-dark.png
5.1 KiB
Márton Lente added 1 commit 2024-10-22 18:36:06 +02:00 
Change My conference filter buttons to toggle-bars for Going and Favorited
items.
Márton Lente requested review from Pablo Vazquez 2024-10-22 18:39:34 +02:00
Márton Lente added 1 commit 2024-10-29 12:06:30 +01:00
Pablo Vazquez commented 2024-10-29 12:41:49 +01:00
Owner
Copy Link

Nice! Seems to work fine.

What do you think of moving the toggle to the right? So it reads from left to right. "Label", "State".

current

proposed

Thanks!

Nice! Seems to work fine. What do you think of moving the toggle to the right? So it reads from left to right. "Label", "State". ![current](/attachments/449cd737-1f7d-4ad9-b7e8-96ce2b776891) ![proposed](/attachments/5360f6c6-959c-41f9-8164-2d6fabae28a6) Thanks!
image.png
15 KiB
image.png
15 KiB
👍 1
Márton Lente added 1 commit 2024-10-29 15:08:58 +01:00
Márton Lente added 1 commit 2024-10-29 15:12:32 +01:00
Márton Lente added 1 commit 2024-10-29 15:15:39 +01:00 
Part of #103981
Márton Lente commented 2024-10-29 15:18:10 +01:00
Author
Owner
Copy Link

What do you think of moving the toggle to the right? So it reads from left to right. "Label", "State".

Thanks! I flipped the order. Maybe it's also better on mobile to have the toggle-bar aligned to the screen's edge.

> What do you think of moving the toggle to the right? So it reads from left to right. "Label", "State". Thanks! I flipped the order. Maybe it's also better on mobile to have the toggle-bar aligned to the screen's edge.
Márton Lente merged commit 9133d6321a into main 2024-10-29 15:20:31 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
legacy project
Infrastructure: Websites

  
Priority
High

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
legacy project
Infrastructure: Websites
Priority
High
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Resolved
Type
Bug
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/conference-website#103981
No description provided.
Delete Branch "ui/my-conference-toggles"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?