infrastructure/devfund-donation-box
0
1
Fork 0
Code Issues Pull Requests Projects Releases 3 Wiki Activity

UI: Devfund-donation-box Web Assets v2 upgrade #1

Merged
Márton Lente merged 26 commits from ui/web-assets-v2-upgrade into main 2024-11-04 12:49:39 +01:00
Conversation 0 Commits 26 Files Changed 18 +311 -273
Márton Lente commented 2024-09-13 16:48:25 +02:00
Owner
Copy Link

This pull request upgrades Git submodule Web Assets to v2, resolves post-upgrade issues, and makes the necessary project-specific changes. It addresses some layout inconsistencies, refactors and simplifies project-level styling, and revises the component build pipeline as well .

Web Assets v2 brings UI fixes, improvements, and new development features to the platform as detailed on the Web Assets v2 guidelines and notes wiki page.

Screenshots:

image

image

This pull request upgrades Git submodule Web Assets to v2, resolves post-upgrade issues, and makes the necessary project-specific changes. It addresses some layout inconsistencies, refactors and simplifies project-level styling, and revises the component build pipeline as well . Web Assets v2 brings UI fixes, improvements, and new development features to the platform as detailed on the Web Assets [v2 guidelines and notes](https://projects.blender.org/infrastructure/web-assets/wiki/v2-guidelines-and-notes.md) wiki page. **Screenshots:** ![image](https://projects.blender.org/attachments/2910efcc-d206-4013-aaf8-8c5d2f4307d2) ![image](https://projects.blender.org/attachments/a7a74f31-c064-41fc-834d-829815899eb2)
devfund-donation-box-web-assets-v2-upgrade-1.png
47 KiB
devfund-donation-box-web-assets-v2-upgrade-2.png
56 KiB
Márton Lente added 13 commits 2024-09-13 16:48:26 +02:00 
Cleanup and remove style imports that are redundant after web-assets v2
upgrade, that ships imported items by default.
Remove custom base styles that are not needed after web-assets v2 upgrade.
Make donate row's horizontal gaps spacings consistent.
Márton Lente added 1 commit 2024-09-13 17:21:33 +02:00
Márton Lente added 1 commit 2024-09-13 18:07:58 +02:00 
Complete refactor and simplify styles custom after web-assets v2 upgrade.
Márton Lente added 1 commit 2024-09-13 18:30:01 +02:00
Márton Lente added 1 commit 2024-09-13 18:33:28 +02:00
Márton Lente added 1 commit 2024-09-16 12:34:29 +02:00
Márton Lente added 1 commit 2024-09-16 12:39:11 +02:00 
Convert spacer utility classes to reflect spacer unit changes visually.
Márton Lente added 1 commit 2024-09-16 12:46:32 +02:00
Márton Lente added 1 commit 2024-09-16 12:54:22 +02:00
Márton Lente changed title from WIP: Devfund-donation-box Web Assets v2 upgrade to UI: Devfund-donation-box Web Assets v2 upgrade 2024-09-16 16:01:38 +02:00
Márton Lente requested review from Pablo Vazquez 2024-09-16 16:03:36 +02:00
Márton Lente added 1 commit 2024-09-16 16:06:08 +02:00
Márton Lente added 1 commit 2024-09-16 16:06:19 +02:00
Pablo Vazquez reviewed 2024-09-16 16:12:23 +02:00
dist/fonts/OFL.txt
@ -0,0 +2,4 @@
This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is copied below, and is also available with a FAQ at:
https://openfontlicense.org
Pablo Vazquez commented 2024-09-16 16:12:23 +02:00
Owner
Copy Link

Sure about this? Their LICENSE.txt file shows 2016 and the current link, no need to change it I guess? https://github.com/rsms/inter/blob/master/LICENSE.txt#L1

Sure about this? Their LICENSE.txt file shows 2016 and the current link, no need to change it I guess? https://github.com/rsms/inter/blob/master/LICENSE.txt#L1
Márton Lente commented 2024-09-16 16:35:33 +02:00
Author
Owner
Copy Link

Thanks for spotting this. The current Inter open font license is what was bundled with the font package as downloaded from Google Fonts. If you think we should rather switch to using the variant (and license) from the repository, let me know. (I think the actual font releases might be the same, as Google hosted open fonts are usually kept up to date – so I think it should be ok as is.)

Thanks for spotting this. The current Inter open font license is what was bundled with the font package as downloaded from [Google Fonts](https://fonts.google.com/specimen/Inter/about). If you think we should rather switch to using the variant (and license) from the repository, let me know. (I think the actual font releases might be the same, as Google hosted open fonts are usually kept up to date – so I think it should be ok as is.)
Pablo Vazquez reviewed 2024-09-16 16:15:51 +02:00
sass/custom.sass Outdated
@ -272,0 +261,4 @@
cursor: pointer
// TODO: move to Web Assets
.fw-title
Pablo Vazquez commented 2024-09-16 16:15:51 +02:00
Owner
Copy Link

// TODO: Move to Web Assets

Isn't that in https://projects.blender.org/infrastructure/web-assets/src/branch/v2/src/styles/bootstrap-5/dist/css/bootstrap-utilities.css#L1274 ?

> // TODO: Move to Web Assets Isn't that in https://projects.blender.org/infrastructure/web-assets/src/branch/v2/src/styles/bootstrap-5/dist/css/bootstrap-utilities.css#L1274 ?
Márton Lente commented 2024-09-16 16:41:10 +02:00
Author
Owner
Copy Link

It is, but Web Assets also applies font-variation-settings rules on top, to make font-weight settings consistently work with variable fonts as well. (The +fw-title mixin should be added – combining font-variation-settings and font-weight rules – to Web Assets similarily to +fw-bold, that already exists.)

It is, but Web Assets also applies `font-variation-settings` rules on top, to make font-weight settings consistently work with variable fonts as well. (The `+fw-title` mixin should be added – combining `font-variation-settings` and `font-weight` rules – to Web Assets similarily to `+fw-bold`, that already exists.)
Pablo Vazquez reviewed 2024-09-16 16:17:35 +02:00
sass/custom.sass Outdated
@ -167,2 +128,2 @@
.rounded-lg
border-radius: var(--border-radius-lg)
// TODO: add style utility to Web Assets
.rounded
Pablo Vazquez commented 2024-09-16 16:17:35 +02:00
Owner
Copy Link

This is also in deprecated
https://projects.blender.org/infrastructure/web-assets/src/branch/v2/src/styles/bootstrap-deprecated/utilities/_borders.scss#L33

This is also in deprecated https://projects.blender.org/infrastructure/web-assets/src/branch/v2/src/styles/bootstrap-deprecated/utilities/_borders.scss#L33
Márton Lente commented 2024-09-16 16:45:33 +02:00
Author
Owner
Copy Link

This rule is currently present both in the deprecated Boostrap partials, and also in the new BS 5 utilities partials. It's because we want to keep this utility once deprecated styles were removed. The latter weren't modified, but renamed in the v2 upgrade: that's why the duplication. *The new rules cascade.

This rule is currently present both in the deprecated Boostrap partials, and also in the new BS 5 utilities partials. It's because we want to keep this utility once deprecated styles were removed. The latter weren't modified, but renamed in the v2 upgrade: that's why the duplication. *The new rules cascade.
Márton Lente added 1 commit 2024-09-16 16:17:55 +02:00 
Part of #1
Pablo Vazquez reviewed 2024-11-01 11:48:25 +01:00
Pablo Vazquez left a comment
Owner
Copy Link

Thanks!

Thanks!
❤️ 1
Márton Lente added 1 commit 2024-11-04 12:29:28 +01:00 
Part of #1
Márton Lente added 1 commit 2024-11-04 12:44:30 +01:00 
Part of #1
Márton Lente merged commit 9a49b8bb41 into main 2024-11-04 12:49:39 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/devfund-donation-box#1
No description provided.
Delete Branch "ui/web-assets-v2-upgrade"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?