infrastructure/devfund-website
0
2
Fork 0
Code Issues 28 Pull Requests Projects 1 Releases Wiki Activity

UI: Devfund-website web-assets v2 upgrade #96867

Merged
Márton Lente merged 12 commits from ui/web-assets-v2-upgrade into main 2024-11-01 16:41:18 +01:00
Conversation 0 Commits 12 Files Changed 27 +140 -111
Márton Lente commented 2024-11-01 15:07:29 +01:00
Owner
Copy Link

This pull request upgrades Git submodule Web Assets to v2, resolves post-upgrade issues, and makes the necessary project-specific changes.

Web Assets v2 brings UI fixes, improvements, and new development features to the platform as detailed on the Web Assets v2 guidelines and notes wiki page.

Visual changes are kept to a minimum and will be visible mainly in minor spacing and typographic adjustments only.

Important:

The following improvements and refactoring tasks are loosely related to the Web Assets v2 upgrade, and can be done after the pull request has been merged:

  • Converting explicit font sizes to variables.
  • Converting explicit spacing sizes to modular sizing.
  • Unifying px and rem units' usage.

The Devfund website hosts the devfund-donation-box project. The latter's upgrade to BWA v2 is managed within its own dedicated repo scope and the following pull request: infrastructure/devfund-donation-box#1

This pull request upgrades Git submodule Web Assets to v2, resolves post-upgrade issues, and makes the necessary project-specific changes. Web Assets v2 brings UI fixes, improvements, and new development features to the platform as detailed on the Web Assets [v2 guidelines and notes](https://projects.blender.org/infrastructure/web-assets/wiki/v2-guidelines-and-notes.md) wiki page. Visual changes are kept to a minimum and will be visible mainly in minor spacing and typographic adjustments only. **Important:** The following improvements and refactoring tasks are loosely related to the Web Assets v2 upgrade, and can be done after the pull request has been merged: - Converting explicit font sizes to variables. - Converting explicit spacing sizes to modular sizing. - Unifying px and rem units' usage. The Devfund website hosts the [devfund-donation-box](https://projects.blender.org/infrastructure/devfund-donation-box) project. The latter's upgrade to BWA v2 is managed within its own dedicated repo scope and the following pull request: https://projects.blender.org/infrastructure/devfund-donation-box/pulls/1
Márton Lente added 9 commits 2024-11-01 15:07:31 +01:00 
Initialize git submodule donation-box to use WIP branch
ui/web-assets-v2-upgrade. This is a beginning step and part of the
project-level web-assets v2 upgrade process.
This reverts commit 0a9aef501e.
Make explicit font-sizes work with global rem sizing changes introduced in
web-assets v2.
Márton Lente added 1 commit 2024-11-01 15:33:15 +01:00
Márton Lente added 1 commit 2024-11-01 15:36:53 +01:00
Márton Lente changed title from WIP: Devfund-website web-assets v2 upgrade to UI: Devfund-website web-assets v2 upgrade 2024-11-01 15:44:28 +01:00
Márton Lente requested review from Pablo Vazquez 2024-11-01 15:44:36 +01:00
Pablo Vazquez requested changes 2024-11-01 15:53:19 +01:00
Dismissed
blender_fund_main/static/blender_fund_main/styles/main.sass Outdated
@ -68,3 +86,3 @@
background-color: hsl(hue(cyan), 100%, 30%)
background-clip: text
-webkit-background-clip: text
-webkit-bg-clip: text
Pablo Vazquez commented 2024-11-01 15:53:11 +01:00
Owner
Copy Link

Typo. -webkit-bg-clip does not exist.

Typo. `-webkit-bg-clip` does not exist.
Márton Lente added 1 commit 2024-11-01 15:56:22 +01:00 
Part of #96867
Márton Lente requested review from Pablo Vazquez 2024-11-01 15:56:47 +01:00
Pablo Vazquez approved these changes 2024-11-01 16:26:52 +01:00
Pablo Vazquez left a comment
Owner
Copy Link

Thanks!

Thanks!
Márton Lente merged commit 952b6a3aed into main 2024-11-01 16:41:18 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
legacy project
Infrastructure: blender.org

  
legacy project
Infrastructure: Websites

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Information from Developers

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
legacy project
Infrastructure: blender.org
legacy project
Infrastructure: Websites
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Information from Developers
Status
Resolved
Type
Bug
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/devfund-website#96867
No description provided.
Delete Branch "ui/web-assets-v2-upgrade"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?