infrastructure/devfund-website
0
2
Fork 0
Code Issues 28 Pull Requests Projects 1 Releases Wiki Activity

Allow accountless membership cancellation via the token #96851

Merged
Oleg-Komarov merged 3 commits from cancel-with-token into main 2024-07-11 19:38:36 +02:00
Conversation 2 Commits 3 Files Changed 6 +105 -15
Oleg-Komarov commented 2024-07-11 18:39:37 +02:00
Owner
Copy Link

infrastructure/webdev-internal#26

When users land on the LinkMembershipView they are forced to login.
If a user didn't have an account, this is confusing because we don't explain
that they need to create one.

Often they land on that page to cancel the membership,
in this case it is especially strange to ask them to create an account.

This PR adds support for a logged-out state in LinkMembershipView
and adds a new CancelMembershipViaTokenView

https://projects.blender.org/infrastructure/webdev-internal/issues/26 When users land on the LinkMembershipView they are forced to login. If a user didn't have an account, this is confusing because we don't explain that they need to create one. Often they land on that page to cancel the membership, in this case it is especially strange to ask them to create an account. This PR adds support for a logged-out state in LinkMembershipView and adds a new CancelMembershipViaTokenView
Oleg-Komarov added 1 commit 2024-07-11 18:39:40 +02:00
Oleg-Komarov added 1 commit 2024-07-11 18:48:00 +02:00
Oleg-Komarov added 1 commit 2024-07-11 18:50:43 +02:00
Oleg-Komarov commented 2024-07-11 18:50:58 +02:00
Author
Owner
Copy Link

image

![image](/attachments/8dbff721-455a-413e-a3b6-edf8d0859931)
image.png
48 KiB
Anna Sirota approved these changes 2024-07-11 18:53:17 +02:00
Anna Sirota left a comment
Owner
Copy Link

LGTM 🎉

LGTM :tada:
Francesco Siddi commented 2024-07-11 19:06:05 +02:00
Owner
Copy Link

As good as it gets!

As good as it gets!
Oleg-Komarov merged commit 9fbd8af0eb into main 2024-07-11 19:38:36 +02:00
Oleg-Komarov deleted branch cancel-with-token 2024-07-11 19:38:37 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Anna Sirota
Labels
Clear labels   
legacy project
Infrastructure: blender.org

  
legacy project
Infrastructure: Websites

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Information from Developers

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
legacy project
Infrastructure: blender.org
legacy project
Infrastructure: Websites
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Information from Developers
Status
Resolved
Type
Bug
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/devfund-website#96851
No description provided.
Delete Branch "cancel-with-token"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?