infrastructure
/
extensions-website
4
6
Fork 4
Code Issues 23 Pull Requests 3 Projects Releases Wiki Activity

Post Web Assets v2 upgrade UI fixes and improvements #114

Merged
Márton Lente merged 35 commits from martonlente/extensions-website:ui/issue105 into main 2024-05-07 16:33:28 +02:00
Conversation 2 Commits 35 Files Changed 18 +241 -149
Márton Lente commented 2024-05-06 14:41:31 +02:00
Owner
Copy Link

Related to issue #105

This pull request fixes Web Assets v2 upgrade issues, and adds UI enhacements as detailed in #105's tasklist, including a notifications system overhaul.

Related to issue #105 This pull request fixes Web Assets v2 upgrade issues, and adds UI enhacements as detailed in #105's tasklist, including a notifications system overhaul.
Márton Lente added 29 commits 2024-05-06 14:41:34 +02:00
4b274407c5 UI: Add js app function agreeWithTerms 
Add JavaScript app function agreeWith terms to enable button submit if agree with terms button is checked.
566368a421 Basic email template for notifications (#96) 
Based on the proposal #93

Email subjects change to the following:

```
Add-on approved: "Genuinely Disgusting"
New comment on Add-on "Genuinely Disgusting"
Add-on rated: "Genuinely Disgusting"
Add-on reported: "Genuinely Disgusting"
Add-on rating reported: "Genuinely Disgusting"
Add-on changes requested: "Genuinely Disgusting"
Add-on review requested: "Genuinely Disgusting"
```

Notification emails can also be viewed in the admin `Email previews` section (with fake objects constructed and passed into email template contexts).

Indicating why the email was sent is not in this change because we currently don't store why **precisely** (can only guess it's either because of `moderators` group or extension follow, the state of either can change after the notification was generated). This can be part of the `Notification` records however, after that the reason can be included in the email.

Reviewed-on: #96
Reviewed-by: Oleg-Komarov <oleg-komarov@noreply.localhost>
84ba9c7c9f Fix KeyError: 'type' for extensions without meaningful statuses in approval queue 
Normally this shouldn't happen, but due to an incomplete data migration #94
we currently have extensions that have only CMT items and miss the AWR one.
def0943c44 UI: Add templates components form fields placeholders 
Add templates components form fields placeholders. Placeholder texts' are as specific as possible based on templates' architecture (so that shared fields have generic placeholder texts).
Márton Lente added 1 commit 2024-05-06 14:53:57 +02:00
Márton Lente added 1 commit 2024-05-06 15:06:08 +02:00
Márton Lente changed title from WIP: Post Web Assets v2 upgrade UI fixes and improvements to Post Web Assets v2 upgrade UI fixes and improvements 2024-05-06 15:42:35 +02:00
Márton Lente added 2 commits 2024-05-06 15:53:15 +02:00
Márton Lente added 1 commit 2024-05-06 18:58:01 +02:00
Márton Lente added 1 commit 2024-05-07 15:19:20 +02:00
73e98b0234 UI: Add template extensions submit noscript behaviour 
Add template extensions submit noscript behaviour to enable extensions' upload when JavaScript is disabled in the browser.
Dalai Felinto commented 2024-05-07 15:38:18 +02:00
Owner
Copy Link

How to test this? I tried checking your ui/issue105 branch and the Upload Extension button is never active:

image

How to test this? I tried checking your ui/issue105 branch and the Upload Extension button is never active: ![image](/attachments/42132c35-af4d-4134-991b-612fc759a116)
image.png
28 KiB
Márton Lente commented 2024-05-07 16:05:55 +02:00
Author
Owner
Copy Link

How to test this? I tried checking your ui/issue105 branch and the Upload Extension button is never active:

image

This has been checked together and seems to be ok.

> How to test this? I tried checking your ui/issue105 branch and the Upload Extension button is never active: > > ![image](/attachments/42132c35-af4d-4134-991b-612fc759a116) This has been checked together and seems to be ok.
Márton Lente merged commit 85e5a21e20 into main 2024-05-07 16:33:28 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Bug
Something is not working

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Security
This is security issue

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Bug
Type
Documentation
Type
Enhancement
Type
Feature
Type
Security
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#114
No description provided.
Delete Branch "martonlente/extensions-website:ui/issue105"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?