Improve validation messages #196

Merged
Dalai Felinto merged 7 commits from pr-error-messages into main 2024-07-01 15:22:55 +02:00

7 Commits

Author SHA1 Message Date
4fe07c2204 From review: Move logic around 2024-07-01 15:19:25 +02:00
bd4f430758 From review: new unittest for OSX 2024-07-01 14:54:29 +02:00
3a811a5002 From review: Unittests
Keep in mind that the test is deliberately failing since the code still cannot handle <strong> in some of the error messages.
2024-07-01 14:42:19 +02:00
55c0d45e1c Update error message based on review 2024-07-01 14:34:48 +02:00
19b9d7f967 Use blockquote instead 2024-07-01 14:34:48 +02:00
dce6f2d66d Using alert-info for the command-line part 2024-07-01 14:34:48 +02:00
0a273a7fc7 WIP: Improve validation messages
1. Prevent duplicate XML error to show up if the __MACOSX error is already present.
2. Add a general "Use the command-line tools" message on the template if any error is present.
3. Use <strong> to highlight some elements of the error messages.

This is marginally related to: #175.

---

TODO: I could not find a way to also have <strong> for missing_wheel and forbidden_filepaths.
My idea is that we could sanitize their parameters first, and then combine with the mark_safe()
error message.

Feel free to take the patch over and finalize it.
2024-07-01 14:34:48 +02:00