Validation Messages: Add <strong> for missing_wheel and forbidden_filepaths #200

Dalai Felinto · 2024-07-02T23:48:05+02:00

Dalai Felinto commented

2024-07-02 23:48:05 +02:00

Note that in order to do this I need to sanitize the parameters separately from the error string.

Dalai Felinto added 1 commit 2024-07-02 23:48:06 +02:00

Validation Messages: Add <strong> for missing_wheel and forbidden_filepaths 328c6ecbc1

Oleg-Komarov reviewed 2024-07-04 13:03:52 +02:00

files/forms.py

						
				@ -42,2 +45,2 @@

				        'missing_wheel': _('Python wheel missing: %(path)s'), # TODO <strong>%(path)s</strong>

				        'forbidden_filepaths': _('Archive contains forbidden files or directories: %(paths)s'), #TODO <strong>%(paths)s</strong>

				        'missing_wheel': _('Python wheel missing: <strong>%(path)s</strong>'),

				        'forbidden_filepaths': mark_safe(

Oleg-Komarov commented

2024-07-04 12:53:46 +02:00

this line and the line above look inconsistent: both of them have parameters, but only one is wrapped into mark_safe inside the error_messages declaration
this is confusing and doesn't establish a consistent pattern for further use: if it's possible it's better to make them the same

it seems that the code below (in clean) already takes care of mark_safe for cases when params are passed, so I would expect that mark_safe in this line is not needed. if this is not true, then the code structure is surprising - we should think how to make it more transparent.

this line and the line above look inconsistent: both of them have parameters, but only one is wrapped into `mark_safe` inside the `error_messages` declaration this is confusing and doesn't establish a consistent pattern for further use: if it's possible it's better to make them the same it seems that the code below (in `clean`) already takes care of `mark_safe` for cases when params are passed, so I would expect that `mark_safe` in this line is not needed. if this is not true, then the code structure is surprising - we should think how to make it more transparent.

files/forms.py

						
				@ -151,3 +153,1 @@

				                            params=code['params'],

				                        )

				                    )

				                    error_message = str(self.error_messages[code['code']])