infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Notifications: unsubscribe from extension approval activity (#177) #207

Merged
Oleg-Komarov merged 5 commits from approval-follow into main 2024-07-30 12:11:05 +02:00
Conversation 1 Commits 5 Files Changed 4 +93 -2
Oleg-Komarov commented 2024-07-15 09:40:44 +02:00
Owner
Copy Link

This PR adds a subscribe/unsubscribe button to the extension's approval page.
The button state is calculated as
actstream.actions.is_following(user, extension, flag=Flag.REVIEWER)

Approval activity notifications are also generated for followers with
Flag.AUTHOR and Flag.MODERATOR.
To avoid confusion the button is hidden from extension maintainers:
it won't suppress any related notifications.
Moderators will see the button, and it will suppress comment notifications
for moderators that interacted with this extension's approval thread,
but it will still allow notifications about review requests.

This PR adds a subscribe/unsubscribe button to the extension's approval page. The button state is calculated as `actstream.actions.is_following(user, extension, flag=Flag.REVIEWER)` Approval activity notifications are also generated for followers with `Flag.AUTHOR` and `Flag.MODERATOR`. To avoid confusion the button is hidden from extension maintainers: it won't suppress any related notifications. Moderators will see the button, and it will suppress comment notifications for moderators that interacted with this extension's approval thread, but it will still allow notifications about review requests.
Oleg-Komarov added 1 commit 2024-07-15 09:40:46 +02:00
Oleg-Komarov added 1 commit 2024-07-16 17:05:24 +02:00
Oleg-Komarov added 1 commit 2024-07-16 17:45:58 +02:00
Oleg-Komarov added 1 commit 2024-07-17 15:34:33 +02:00
Oleg-Komarov changed title from WIP: Notifications: unsubscribe from extension approval activity (#177) to Notifications: unsubscribe from extension approval activity (#177) 2024-07-22 10:54:16 +02:00
Oleg-Komarov commented 2024-07-22 10:55:16 +02:00
Author
Owner
Copy Link

This PR is missing a proper styling/layout for the new button.
cc @martonlente

This PR is missing a proper styling/layout for the new button. cc @martonlente
👍 1
Márton Lente added 1 commit 2024-07-30 11:58:07 +02:00 
Improve approval activity subscription buttons' display and layout
in template reviewers extensions_review_detail.
Part of #177
Anna Sirota approved these changes 2024-07-30 12:10:43 +02:00
Anna Sirota left a comment
Owner
Copy Link

awesome sauce! 🎉

awesome sauce! :tada:
Oleg-Komarov merged commit 709685e2c0 into main 2024-07-30 12:11:05 +02:00
Oleg-Komarov deleted branch approval-follow 2024-07-30 12:11:05 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Anna Sirota
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#207
No description provided.
Delete Branch "approval-follow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?