Can you add some more information to the patch description?
Just checked, indeed little provided :)
Problem is with this variable, captures by reference go crazy in Release
build.
Crash in release, but not in debug? Do you on MSVC?
MacOS, VSCode.
Don't know if it is same thing, but I was cheking blender/blender#117709 on XCode.…
OK. Unless you suggest removing Span
variable completely.
In that case I don't like the fact that in functions like select_box
conversion to Span
will happen several times.
I prefer getting…
That is what I was talking about yesterday :)
In that case Vector
would be temporary (or r-value) and it's destructor will get called just before leaving expression. The Span
will be left…
Removed argument, but now it is tempting to use a one-liner:
MutableSpan<bke::GSpanAttributeWriter> selections = init_selection_writers(curves, selection_domain);
Returning by value looks…
I like to put const
everywhere I can as a quick hint for eyes, that variable is not intended to change. Maybe it could save from faulty using it as reference.
But don't have deep attachment to…
It has default value for the attribute_name
in a header. Should I add third version of retrieve_selected_points
?