Laurynas Duburas laurynas
  • Joined on 2021-06-10
Laurynas Duburas commented on pull request blender/blender#119712 2024-04-03 10:40:20 +02:00
Curves: Bezier handle selection support

Can you add some more information to the patch description?

Just checked, indeed little provided :)

Laurynas Duburas deleted branch fix_nurbs_curve_with_a_single_point from laurynas/blender 2024-04-02 23:20:16 +02:00
Laurynas Duburas created branch fix_nurbs_curve_with_a_single_point in laurynas/blender 2024-04-02 22:13:09 +02:00
6da7ad8f3b Fix #117709: NURBS curve with a single point crashes Blender
d1b6621903 UI: Complete Event Icon Coverage
65bfae2258 UI: Status Bar Keymap Spacing
930d645b4c Fix #120154: Cage face normals overlay always draws original normals
6160335c4d Cleanup: Extract common functions in sculpt_trim.cc
Compare 10 commits »
Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-04-02 21:26:04 +02:00
612977f854 FunctionRef to auto for variable type
Laurynas Duburas commented on pull request blender/blender#119712 2024-04-02 21:14:45 +02:00
Curves: Bezier handle selection support

Problem is with this variable, captures by reference go crazy in Release build.

Laurynas Duburas commented on issue blender/blender#117709 2024-04-02 19:50:28 +02:00
NURBS curve with a single point crashes Blender

On M1 Max brk #0x01 instruction is compiled in after RPT_("At least two points required") call.

assembly.png

When writing `BKE_nurb_v…

Laurynas Duburas commented on pull request blender/blender#119712 2024-04-02 19:11:27 +02:00
Curves: Bezier handle selection support

Crash in release, but not in debug? Do you on MSVC?

MacOS, VSCode.

Don't know if it is same thing, but I was cheking blender/blender#117709 on XCode.…

Laurynas Duburas commented on pull request blender/blender#119712 2024-04-02 18:59:01 +02:00
Curves: Bezier handle selection support

Don't merge it yet. It crashes on Release build.

Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-04-02 18:45:40 +02:00
fdde4e7ca3 Span<bke::GSpanAttributeWriter> removed
Laurynas Duburas commented on pull request blender/blender#119712 2024-04-02 14:18:38 +02:00
Curves: Bezier handle selection support

OK. Unless you suggest removing Span variable completely. In that case I don't like the fact that in functions like select_box conversion to Span will happen several times. I prefer getting…

Laurynas Duburas commented on pull request blender/blender#119712 2024-04-02 14:04:26 +02:00
Curves: Bezier handle selection support

That is what I was talking about yesterday :) In that case Vector would be temporary (or r-value) and it's destructor will get called just before leaving expression. The Span will be left…

Laurynas Duburas commented on pull request blender/blender#119712 2024-04-01 21:12:02 +02:00
Curves: Bezier handle selection support

Removed argument, but now it is tempting to use a one-liner:

MutableSpan<bke::GSpanAttributeWriter> selections = init_selection_writers(curves, selection_domain);

Returning by value looks…

Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-04-01 21:11:58 +02:00
0825c0e1c4 Return value of init_selection_writers
Laurynas Duburas commented on pull request blender/blender#119712 2024-04-01 20:24:44 +02:00
Curves: Bezier handle selection support

I like to put const everywhere I can as a quick hint for eyes, that variable is not intended to change. Maybe it could save from faulty using it as reference. But don't have deep attachment to…

Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-04-01 20:24:39 +02:00
ea7fa93765 Various fixes
b5766fee8c Span<std::string> to Span<StringRef>
6fb0f808ff std::string to StringRef
Compare 3 commits »
Laurynas Duburas commented on pull request blender/blender#119712 2024-04-01 19:18:39 +02:00
Curves: Bezier handle selection support

I'm doing it, but just for the future: what is the benefit?

Laurynas Duburas commented on pull request blender/blender#119712 2024-04-01 19:15:09 +02:00
Curves: Bezier handle selection support

It has default value for the attribute_name in a header. Should I add third version of retrieve_selected_points?

Laurynas Duburas commented on pull request blender/blender#119712 2024-04-01 19:06:23 +02:00
Curves: Bezier handle selection support

Sorry, I was in a hurry. You told me this already.

Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-04-01 13:39:05 +02:00
853cefa9fa Leftovers of AttributeIDRef to std::string and other