Laurynas Duburas laurynas
  • Joined on 2021-06-10
Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-04-01 20:24:39 +02:00
ea7fa93765 Various fixes
b5766fee8c Span<std::string> to Span<StringRef>
6fb0f808ff std::string to StringRef
Compare 3 commits »
Laurynas Duburas commented on pull request blender/blender#119712 2024-04-01 19:18:39 +02:00
Curves: Bezier handle selection support

I'm doing it, but just for the future: what is the benefit?

Laurynas Duburas commented on pull request blender/blender#119712 2024-04-01 19:15:09 +02:00
Curves: Bezier handle selection support

It has default value for the attribute_name in a header. Should I add third version of retrieve_selected_points?

Laurynas Duburas commented on pull request blender/blender#119712 2024-04-01 19:06:23 +02:00
Curves: Bezier handle selection support

Sorry, I was in a hurry. You told me this already.

Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-04-01 13:39:05 +02:00
853cefa9fa Leftovers of AttributeIDRef to std::string and other
Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-04-01 13:16:01 +02:00
b44ef0f94b Implementation to .cc and typo fix
Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-03-30 17:47:23 +01:00
8fa41ee4e7 Fix crash on select in empty curve
Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-03-30 00:15:46 +01:00
a684dcc5d4 Bug with IndexMask slicing
Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-03-29 18:56:32 +01:00
d6567db902 Fixes selection after duplicate points or curves
Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-03-29 13:51:21 +01:00
42e2f13dc6 Class SelectionAttributeWriterList removed
6fc407db68 Exception fixed
Compare 2 commits »
Laurynas Duburas commented on pull request blender/blender#119712 2024-03-27 22:09:38 +01:00
Curves: Bezier handle selection support

not sure if float selection may be allowed here.

Use case. Create empty hair, go to sculpt mode, add some curves and Paint select something. Go to edit mode and box select. In `select_box()>>fil…

Laurynas Duburas commented on pull request blender/blender#119712 2024-03-26 21:33:45 +01:00
Curves: Bezier handle selection support

With get_curves_bezier_selection_attribute_names this one should look better, but the reasoning for whole for loop still stays deeper.

Laurynas Duburas commented on pull request blender/blender#119712 2024-03-26 21:25:44 +01:00
Curves: Bezier handle selection support

Added function get_curves_bezier_selection_attribute_names. I think it is good now.

Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-03-26 21:17:46 +01:00
678f814b5e Condition for NURBS case fixed
Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-03-26 21:12:17 +01:00
ad22fae111 Other fixes
Laurynas Duburas commented on pull request blender/blender#119712 2024-03-26 13:55:00 +01:00
Curves: Bezier handle selection support

No. I think it is answered in the reply below.

Laurynas Duburas commented on pull request blender/blender#119712 2024-03-26 13:52:39 +01:00
Curves: Bezier handle selection support

for loop's body here will be executed either twice or will be skipped. I prefer here for over if with the body repeated twice, to avoid later mistakes on changes. Furthermore with if

Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-03-26 12:53:22 +01:00
86834b59a2 Functions foreach_selectable_* commented
Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-03-26 12:17:04 +01:00
85b80daae5 Variuos small fixes
Laurynas Duburas pushed to select-bezier-handles at laurynas/blender 2024-03-26 10:05:30 +01:00
50c9f80ded get_curves_selection_attribute_names refactored