@devin-bayly Per our direct discussion yesterday, I opened pull request blender/blender#120060 based on your branch.
This implementation looks good. I would recommend extending it as follows:
- Handle more point attribute types.
- Extend
USDPointsReader::is_animated()to handle animating attributes in…
Yes, it could be that you did not fork the original blender source repo.
Did you originally follow this setup: https://developer.blender.org/docs/handbook/contributing/pull_requests/#one-time-s…
Yes, it should go to blender:main. I'm not sure why you're not seeing it. Maybe something went wrong when you copied my branch. How did you copy my branch?
In any case, maybe try copying…
Hi @devin-bayly. Thanks for following up! I see your copy of the branch, but did you create the pull request?
https://developer.blender.org/docs/handbook/contributing/pull_requests/#create-a-p…
Hi @devin-bayly . I made this branch that has your changes from devin-bayly-patch-2-clean applied to the latest main:
https://projects.blender.org/makowalski/blender/src/branch/usd-points-i…
Hi @devin-bayly. The branch you're working on is very much out of date with main. As a first step, I'd like to apply the changes you have cleanly to top of main so we have a branch we can use to…
This looks good. Thanks for adding the tests.
@brecht I suppose another option might be to implement Cycles to USD conversion as a Python export hook, but I haven't thought through all the pros and cons of doing it that way.
Hi @devin-bayly. I'll take a look at this in the next day or so. I'm sorry for the delay on my part, and thanks for all the hard work!