Michael Kowalski makowalski
  • Joined on 2020-09-17
Michael Kowalski commented on pull request blender/blender#113107 2023-10-20 22:04:32 +02:00
USD PointInstancer import support

@expenses @CharlesWardlaw I haven't had a chance to look at this PR yet, but please be aware there is already work in progress on Point Cloud import:

https://projects.blender.org/blender/blende

Michael Kowalski closed pull request blender/blender#113187 2023-10-20 17:00:15 +02:00
USD: export to a single root prim by default
Michael Kowalski commented on pull request blender/blender#113187 2023-10-20 17:00:13 +02:00
USD: export to a single root prim by default

I merged this manually in order to fix a conflict and am closing this PR.

Michael Kowalski pushed to main at blender/blender 2023-10-20 16:58:58 +02:00
b262655d39 USD: export to a single root prim by default
Michael Kowalski commented on pull request blender/blender#112298 2023-10-19 23:18:47 +02:00
USD: Fix for spammy attribute prints for unsupported and non-array attributes

@CharlesWardlaw I think this pull request should merge into the blender-v4.0-release branch and not into main.

Michael Kowalski approved blender/blender#113883 2023-10-19 22:29:13 +02:00
Fix USD I/O crashing on reports by using new wmJob report system.

These changes look good and work well in my tests. Thank you for the fix!

Michael Kowalski approved blender/blender#113187 2023-10-19 16:47:41 +02:00
USD: export to a single root prim by default

Thanks for the updates! The changes look good!

Michael Kowalski commented on pull request blender/blender#113187 2023-10-19 16:29:32 +02:00
USD: export to a single root prim by default
Michael Kowalski pushed to main at blender/blender 2023-10-18 16:02:01 +02:00
d96b137188 Merge branch 'blender-v4.0-release'
686487ca17 Fix: USD: Use color3f for color nodes
Compare 2 commits »
Michael Kowalski merged pull request blender/blender#113695 2023-10-18 14:52:15 +02:00
Fix: USD: Use color3f for color nodes
Michael Kowalski pushed to blender-v4.0-release at blender/blender 2023-10-18 14:52:15 +02:00
686487ca17 Fix: USD: Use color3f for color nodes
Michael Kowalski approved blender/blender#113695 2023-10-17 18:17:52 +02:00
Fix: USD: Use color3f for color nodes

This change looks good. Thank you for the fix!

Michael Kowalski commented on issue blender/blender#106398 2023-10-16 23:07:32 +02:00
UsdGeomPoints import support

Hi @devin-bayly. Nice progress!

Ok, so integrating that code from above I have the color being brought in. I'm curious what the correct name would be to have blender automatically pick up…

Michael Kowalski commented on pull request blender/blender#113695 2023-10-16 16:16:26 +02:00
Fix: USD: Use color3f for color nodes

If we want this as a bug fix for 4.0, then this pull request should be changed to merge into blender-v4.0-release rather than into main. Thanks!

Michael Kowalski commented on pull request blender/blender#113187 2023-10-13 23:41:29 +02:00
USD: export to a single root prim by default

If you don't mind, can you please run 'make format' to fix the formatting, please?

Otherwise, apart from the minor comment regarding adding a leading slash to the default root path, this looks…

Michael Kowalski commented on pull request blender/blender#113187 2023-10-13 23:16:37 +02:00
USD: export to a single root prim by default

Maybe the default string should be "/root", so we don't have to prepend the leading slash each time?

Michael Kowalski commented on pull request blender/blender#113187 2023-10-13 15:32:01 +02:00
USD: export to a single root prim by default

I'm currently reviewing this. Sorry for the delay.

Michael Kowalski commented on pull request blender/blender#113548 2023-10-13 15:18:50 +02:00
Make wmJob worker thread use their own reports list instead of WM one.

Also, I think USD I/O code is currently fairly abusing the Report system... Lots of these messages should rather be processed through the logging system imho (se are using CLOG), reports should…

Michael Kowalski commented on pull request blender/blender#113548 2023-10-12 23:46:01 +02:00
Make wmJob worker thread use their own reports list instead of WM one.

Thank you so much for this important fix!

The USD implementation looks good to me and works in my test. Since you mentioned that the USD related changes will likely be submitted separately, I…

Michael Kowalski commented on pull request blender/blender#113548 2023-10-12 03:32:56 +02:00
Make wmJob worker thread use their own reports list instead of WM one.

@makowalski would love to have your PoV on USD-related changes in this code.

I will aim to finish my review tomorrow, but so far the changes look good!