- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
Looks good to me! I just have one comment, but it might be best to address it in a separate cleanup PR.
It feels weird to me that this is in autokey_flag when it's not specific to auto keying. I think this should be cleaned up to put the flag in a more obviously "for all keying" place, but not sure if that belongs in this PR or if it should be a separate cleanup PR. I'll leave that to you.
BKE_fcurve_bezt_binarysearch_index is all comparison based, so it should work fine. (And it has special cases to optimize for before/after the first/last frames as well, to avoid the whole…
Oh yeah, this feels much better!
Is there a reason you went with FLT_MAX instead of INFINITY? It doesn't make a practical difference either way, so I'm happy as-is. Mainly just curious,…
The assert was making me nervous, so I looked into it. It was caused by 9dcf73c7157f342cb16092b4e47864777a59a4f1 which was committed a few days before your PR and added that assert. Turns out…
I wonder what people think of having the preference in Editing->Objects->New Objects rather than Animation > Armature > Default Bone Orientation.
I think that actually might make more sense,…
When trying to grab keyframes in either the action editor or dopesheet editor, Blender is aborting with the following assert:
BLI_assert failed: /home/guest/Projects/blender/blender/sourc…Using a C-style array to make the range argument optional feels somehow dirty to me here because we're always passing a blender::float2, which is a nice POD type. Having said that, I'm not thrilled about the alternatives I can think of either:
