Nathan Vegdahl nathanvegdahl
  • Amsterdam, Netherlands
  • https://cessen.com
  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Nathan Vegdahl commented on pull request blender/blender#121525 2024-05-07 17:54:07 +02:00
Refactor: centralize responsibility for "Only Insert Needed"

🤦 Thanks for catching that! I'll look into it as well, of course. :-)

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-05-07 16:49:13 +02:00
5a30806d5c Update reports/2024.md
Nathan Vegdahl created pull request blender/blender#121528 2024-05-07 16:45:45 +02:00
Cleanup: use "EXPECT" instead of "ASSERT", and rewrap a failure message
Nathan Vegdahl pushed to anim_test_updates at nathanvegdahl/blender 2024-05-07 16:44:49 +02:00
1dde21926c Cleanup: use "EXPECT" instead of "ASSERT", and rewrap a failure message
Nathan Vegdahl pushed to anim_test_updates at nathanvegdahl/blender 2024-05-07 16:42:31 +02:00
4bc198bae2 Cleanup: use "EXPECT" instead of "ASSERT", and rewrap messages
Nathan Vegdahl pushed to anim_test_updates at nathanvegdahl/blender 2024-05-07 16:41:18 +02:00
a0d78f7275 Cleanup: use "EXPECT" instead of "ASSERT", and rewrap messages
Nathan Vegdahl created branch anim_test_updates in nathanvegdahl/blender 2024-05-07 16:41:18 +02:00
Nathan Vegdahl commented on pull request blender/blender#120428 2024-05-07 16:13:10 +02:00
Anim: implement 3D viewport keyframing functionality for the Animation data-block

Got it. If that gets addressed for the other report messages in main first, then I'll update these ones as well before merging. Otherwise I think it makes sense to merge as-is, and then they can…

Nathan Vegdahl pushed to centralize_only_insert_needed at nathanvegdahl/blender 2024-05-07 16:07:19 +02:00
7b03b718e5 Make `new_key_needed()` take fcurve as a reference
Nathan Vegdahl commented on pull request blender/blender#121525 2024-05-07 15:59:11 +02:00
Refactor: centralize responsibility for "Only Insert Needed"

Note to reviewers: this is changed to INSERTKEY_NOFLAGS because the flag previously passed was actually not used by insert_vert_fcurve(), but now is. So this actually preserves the previous behavior.

Nathan Vegdahl pushed to centralize_only_insert_needed at nathanvegdahl/blender 2024-05-07 15:52:22 +02:00
f0d45c42ab Blindly keep previous behavior where "Insert Only Needed" was ignored.
Nathan Vegdahl pushed to centralize_only_insert_needed at nathanvegdahl/blender 2024-05-07 15:34:37 +02:00
6d531a21b1 Make argument order of `KeyframeStrip::keyframe_insert()` consistent with `insert_vert_fcurve()`
Nathan Vegdahl created pull request blender/blender#121525 2024-05-07 15:28:34 +02:00
WIP: Refactor: centralize responsibility for "Only Insert Needed"
Nathan Vegdahl pushed to centralize_only_insert_needed at nathanvegdahl/blender 2024-05-07 15:26:12 +02:00
c6fb16b05d Merge branch 'main' into centralize_only_insert_needed
d6aa790301 Cleanup: EEVEE-Next: Remove warnings
0b7985a58b EEVEE-Next: Increase shadow precision in render tests
8dbd167e80 Anim: add failure propagation to more lower-level keying functions
87d164c56b EEVEE-Next: Improve shadow tracing
Compare 13 commits »
Nathan Vegdahl pushed to centralize_only_insert_needed at nathanvegdahl/blender 2024-05-07 15:13:40 +02:00
78683a850b Refactor: centralize responsibility for "Only Insert Needed"
Nathan Vegdahl created branch centralize_only_insert_needed in nathanvegdahl/blender 2024-05-07 15:13:40 +02:00
Nathan Vegdahl deleted branch keyframing_failure_propagation from nathanvegdahl/blender 2024-05-07 15:07:13 +02:00
Nathan Vegdahl merged pull request blender/blender#121517 2024-05-07 15:07:09 +02:00
Anim: add failure propagation to more lower-level keying functions
Nathan Vegdahl pushed to main at blender/blender 2024-05-07 15:07:08 +02:00
8dbd167e80 Anim: add failure propagation to more lower-level keying functions