Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl commented on pull request blender/blender#110135 2023-10-19 12:58:55 +02:00
Drivers: implement fallback values for RNA path based variables.

Maybe slightly better wording:

Nathan Vegdahl commented on pull request blender/blender#110135 2023-10-19 12:58:54 +02:00
Drivers: implement fallback values for RNA path based variables.

Shouldn't the second part of the condition here be the same as on line 44: dtar->options & DTAR_OPTION_USE_FALLBACK? And then also set `dtar->flag

Nathan Vegdahl pushed to main at nathanvegdahl/blender 2023-10-17 17:56:23 +02:00
48e60dcbff Fix: GPv3: Compile error
07749b389d GPv3: Convert radius to blender units
5139a3a09f Merge branch 'blender-v4.0-release' into main
6ecef4d176 Fix crash when Transform Extend multiple NLA strips
6f125661e6 GPU: Add Texture::debug_clear
Compare 8 commits »
Nathan Vegdahl pushed to hierarchical_bone_collections at nathanvegdahl/blender 2023-10-17 17:56:13 +02:00
48e60dcbff Fix: GPv3: Compile error
07749b389d GPv3: Convert radius to blender units
5139a3a09f Merge branch 'blender-v4.0-release' into main
6ecef4d176 Fix crash when Transform Extend multiple NLA strips
6f125661e6 GPU: Add Texture::debug_clear
Compare 8 commits »
Nathan Vegdahl created branch hierarchical_bone_collections in nathanvegdahl/blender 2023-10-17 17:56:13 +02:00
Nathan Vegdahl pushed to main at nathanvegdahl/blender 2023-10-17 13:50:49 +02:00
79cbeae939 Vulkan: Incorrect Node Socket Drawing
da2e951512 Cleanup: Make format
fd192188cd Merge branch 'blender-v4.0-release'
8867cfc563 Fix #113778: Skip unlinking a linked collection if parent is linked
31ec00895f Curves: Add edit mode operator to set attribute values
Compare 1204 commits »
Nathan Vegdahl pushed to anim/animation-id-113594 at nathanvegdahl/blender 2023-10-17 13:49:54 +02:00
9ddfe57d99 Anim: remove unused variables
0e9edee46b Merge remote-tracking branch 'origin/main' into anim/animation-id-113594
4a11755458 GPv3: Curve to Mesh node
1b85ca7b05 Fix: GPv3: Reorder layers missing update
f4e584b02a BLI: Math Vector: Add reduce_min/max/add and average function
Compare 119 commits »
Nathan Vegdahl suggested changes for blender/blender#110135 2023-10-17 11:52:42 +02:00
Drivers: implement fallback values for RNA path based variables.

Continuing my review. Still have more to go. So far, just nits. Looking good!

Nathan Vegdahl commented on pull request blender/blender#110135 2023-10-17 11:52:41 +02:00
Drivers: implement fallback values for RNA path based variables.

I think it would read a little better if ads was just passed to fcurve_has_errors() itself, and then the flag check can be done in there.

Nathan Vegdahl commented on pull request blender/blender#110135 2023-10-17 11:52:41 +02:00
Drivers: implement fallback values for RNA path based variables.

Is there a semantic difference between passing "" vs nullptr to uiItemR() here? If not, let's be consistent. It looks like most calls to uiItemR() are passing nullptr when there's no value.

Nathan Vegdahl commented on pull request blender/blender#110135 2023-10-17 11:52:40 +02:00
Drivers: implement fallback values for RNA path based variables.

The comment here is fairly redundant with the name. Maybe add a tiny bit more detail, like:

Nathan Vegdahl commented on pull request blender/blender#110135 2023-10-17 10:40:36 +02:00
Drivers: implement fallback values for RNA path based variables.

Well, the fallback is provided for the case when resolving the RNA path fails.

Is it not triggered if the ID pointer is empty? Although even more niche, I could that also being useful, if…

Nathan Vegdahl approved blender/blender#110121 2023-10-16 16:37:11 +02:00
Fix #113552: NLA Markers do not reset when length reaches 0.0

Looks good to me!

Nathan Vegdahl suggested changes for blender/blender#110135 2023-10-16 12:05:05 +02:00
Drivers: implement fallback values for RNA path based variables.

Just a partial review so far (haven't made it through all the code yet). So far it's looking good code-wise. Just one minor nit.

Nathan Vegdahl commented on pull request blender/blender#110135 2023-10-16 12:05:04 +02:00
Drivers: implement fallback values for RNA path based variables.

Use nullptr instead of NULL.

Nathan Vegdahl commented on pull request blender/blender#110135 2023-10-16 11:35:26 +02:00
Drivers: implement fallback values for RNA path based variables.

Some feedback from testing:

  • The fallback option seems to only exist for Single Property and Context Property variable types. I think that's probably fine for now, but maybe that could be…
Nathan Vegdahl commented on issue blender/blender#88752 2023-10-16 11:08:45 +02:00
Setting an overlapping IK constraint to zero influence/disabled gives weird behavior

@Isaac-Burke Can you please file another issue for that, with a clear example and minimal demo .blend file? That will make it easier track, and will also let us figure out more easily if your…

Nathan Vegdahl commented on pull request blender/blender#110121 2023-10-16 10:56:54 +02:00
Fix #113552: NLA Markers do not reset when length reaches 0.0

so I decided to rebase onto main

Oh! Also, please rebase onto and change the PR to merge to blender-v4.0-release, because we'll merge there first.

Nathan Vegdahl commented on pull request blender/blender#110121 2023-10-16 10:51:59 +02:00
Fix #113552: NLA Markers do not reset when length reaches 0.0

Thanks @mano-wii !

I don't know if we need to (or should) mention specific functions in the comment in this case. To me, at least, it's not clear where the zero-length strip lengths are coming…

Nathan Vegdahl pushed to anim/animation-id-113594 at nathanvegdahl/blender 2023-10-13 16:15:49 +02:00
97d9690013 Fix: crash when building depsgraph relations for strip channels