- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
According to the style guide, float literals are supposed to be written 1.0f as it was before. I don't feel strongly about this myself, but since it was already that way, and that adheres to the style guide, I think it's best to leave it as it was.
From blender.chat:
AlexanderGavrilov smat is mat_accum - the code for non-preserve volume is using the pointer as a flag, so I did the same, even though it's a bit weird in this…
Thanks for putting the work in on this! Everything works great in my testing, and the code generally looks good. Just some nits I'd like addressed and some questions.
How sure are you that world_to_object is valid here? The previous code was computing this from object_to_world, which makes me wonder if world_to_object isn't always guaranteed to be up-to-date when this function is called.
It's not clear to me why the last parameter here is based on whether mat_accum is null or not, especially since mat_accum doesn't seem to be used at all if we're in this branch. Can you add a comment documenting that?
This was easier for me to follow when it was rolled into the code around lines 370-380 ish. Is moving the code up here a bug fix, or is it just a stylistic change? If it's just stylistic, please revert.
Further investigation into the crashes revealed that there are multiple underlying issues, any of which can cause crashes:
- The armature undo code in
editors/armature/editarmature_undo.cc…