Joerg Mueller neXyon
1 Followers · 0 Following
  • Joined on 2009-02-04
Repositories
1
 Projects Public Activity Starred Repositories
Joerg Mueller pushed to main at blender/blender 2024-05-06 08:28:49 +02:00
a5ba4032e0 Audaspace: porting bugfixes for CoreAudioDevice from upstream.
Joerg Mueller commented on issue blender/blender#120726 2024-05-02 22:19:05 +02:00
Regression: animated scene audio volume not changing the audible volume on playback

This is all related to the detailed discussion I made 3 years ago, where I mostly quote a long post from 6 years ago: https://devtalk.blender.org/t/better-audio-integration/17810

I would love…

Joerg Mueller commented on issue blender/blender#120726 2024-05-02 00:10:07 +02:00
Regression: animated scene audio volume not changing the audible volume on playback

Could be possible, might introduce some audible issues though: The audio library distinguishes between animated and non-animated properties (i.e., constant value). If it's animated, you have to…

Joerg Mueller commented on issue blender/blender#120726 2024-04-25 18:54:17 +02:00
Regression: animated scene audio volume not changing the audible volume on playback

Thanks for the investigation @dr.sybren ! Unfortunately, I don't know what the ideal place would be to implement this. Maybe @Sergey or @iss ?

Joerg Mueller commented on issue blender/blender#120726 2024-04-19 15:58:10 +02:00
Regression: animated scene audio volume not changing the audible volume on playback

You're right, my mistake, sorry! I investigated a little bit. It's apparently an issue of the depsgraph, since all the functions that should be called to update the volume are basically never…

Joerg Mueller commented on issue blender/blender#120726 2024-04-17 18:03:20 +02:00
Regression: animated scene audio volume not changing the audible volume on playback

This is a bug in the UI, not sure where it comes from. This value should not be animatable, since PROP_ANIMATABLE is cleared in rna_scene.cc.

Joerg Mueller approved blender/blender#120072 2024-03-29 19:11:01 +01:00
Fix: Crash/Assert in the pusleaudio lib when pausing playback

Great find! Thanks for the fix!

Joerg Mueller pushed to main at blender/blender 2024-03-08 17:02:41 +01:00
91eb50ec2f Audaspace: Bugfix for PulseAudio ported from upstream.
Joerg Mueller pushed to main at blender/blender 2024-03-05 18:23:45 +01:00
43307b667d Audaspace: porting changes from upstream.
Joerg Mueller commented on pull request blender/blender#107607 2024-02-29 23:25:23 +01:00
Audaspace: Load CoreAudio device on demand

Sorry for taking some time to respond, I'm as busy as usual. The patch looks good and you're right, the code probably doesn't get much better if you derive from ThreadedDevice. I've made minor…

Joerg Mueller reopened issue blender/blender#114801 2024-01-17 17:50:27 +01:00
scene.use_audio parameter's boolean seems to function wrong way round in Blender 3.6.5
Joerg Mueller commented on issue blender/blender#114801 2024-01-17 17:50:23 +01:00
scene.use_audio parameter's boolean seems to function wrong way round in Blender 3.6.5

Sorry, hit the wrong button before finishing. What do you think @ideasman42 ?

Joerg Mueller closed issue blender/blender#114801 2024-01-17 17:49:47 +01:00
scene.use_audio parameter's boolean seems to function wrong way round in Blender 3.6.5
Joerg Mueller commented on issue blender/blender#114801 2024-01-17 17:49:43 +01:00
scene.use_audio parameter's boolean seems to function wrong way round in Blender 3.6.5

Well, if it's not used much, why not fix it with one of the other 2 options? Probably 2 is the cleanest?

Joerg Mueller commented on issue blender/blender#114801 2023-11-16 17:15:08 +01:00
scene.use_audio parameter's boolean seems to function wrong way round in Blender 3.6.5

@ideasman42 how would you like to solve this issue? I see three options:

  1. keep as is to not break anything depending on it
  2. change the behavior to work correctly (i.e. negate `rna_Scene_use…
Joerg Mueller commented on pull request blender/blender#107607 2023-09-23 16:02:48 +02:00
Audaspace: Load CoreAudio device on demand

Overall changes look good now! I've added some comments inline of what I'd like to see changed still and additionally:

Joerg Mueller commented on pull request blender/blender#107607 2023-09-23 16:02:48 +02:00
Audaspace: Load CoreAudio device on demand

Please use chrono instead of ctime.

Joerg Mueller commented on pull request blender/blender#107607 2023-09-23 16:02:47 +02:00
Audaspace: Load CoreAudio device on demand

Please don't mix std::chrono code with ctime code, just use std::chrono everywhere!

Joerg Mueller commented on pull request blender/blender#107607 2023-09-23 16:02:47 +02:00
Audaspace: Load CoreAudio device on demand

I dislike the hardcoding of this value, especially since it reappears just a few lines below again. Maybe you could turn this into a proper variable and even base it on some other value that makes sense (see e.g. sleep_duration in WASAPIDevice.cpp:95).

Joerg Mueller commented on pull request blender/blender#107607 2023-09-15 09:24:12 +02:00
Audaspace: Load CoreAudio device on demand

Not sure what you mean? Do you mean running clang-format as auto-formatter? Clang format can also be run on just the changes in a diff which would be ideal here. So, can you apply the cleanup…