Sahar A. Kashi salipour
2 Followers · 0 Following
  • Joined on 2022-02-10
Repositories
1
 Projects Public Activity Starred Repositories
Sahar A. Kashi pushed to point_cloud_deformation_motion at salipour/AMD_HIPRT 2024-09-05 21:58:40 +02:00
89cc3cc83a added #ifdef for point cloud and object motion
Sahar A. Kashi commented on pull request blender/blender#127163 2024-09-05 20:31:53 +02:00
Fix #127131: Deforming motion blurred point clouds do not render in Cycles HIP-RT when BVH timesteps != 0

Generally looks fine, and works better than it used to. There are a couple of comments about keeping the ifdef.

The issue I've run into is: i was testing this patch on Linux on top of…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-09-05 03:35:24 +02:00
Cycles: Linux Support for HIP-RT

@LazyDodo and @Sergey
That's the simplest way I could come up with 9333515ce3 Let me know if I need to make…

Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-09-05 03:32:35 +02:00
9333515ce3 Updating hiprt find module for more clarity
b63350cc48 Merge branch 'HIPRT_OPEN_SOURCE' of projects.blender.org:salipour/AMD_HIPRT into HIPRT_OPEN_SOURCE
3f9574a50d Merge branch 'main' into HIPRT_OPEN_SOURCE
Compare 3 commits »
Sahar A. Kashi pushed to point_cloud_deformation_motion at salipour/AMD_HIPRT 2024-09-05 01:02:28 +02:00
09192f2a3b Fix: Deforming motion blurred point clouds
Sahar A. Kashi created pull request blender/blender#127163 2024-09-05 01:00:33 +02:00
Fix: Deforming motion blurred point clouds do not render in Cycles HIP-RT when BVH timesteps != 0
Sahar A. Kashi created branch point_cloud_deformation_motion in salipour/AMD_HIPRT 2024-09-05 00:51:54 +02:00
Sahar A. Kashi pushed to point_cloud_deformation_motion at salipour/AMD_HIPRT 2024-09-05 00:51:54 +02:00
89095826fd Fix: Debug build error after recent cleanup
d84522390c Sculpt: Ignore sharp faces when building BVH tree
d7d19ec297 Sculpt: Push multiple undo nodes at once for some operations
c21ec8221d Refactor: Sculpt: Split mesh and grids undo data storage
b14badf3ea Cleanup: Subdiv: Use Span and float3 for vertex positions
Compare 10 commits »
Sahar A. Kashi commented on issue blender/blender#127131 2024-09-04 16:58:27 +02:00
Deforming motion blurred point clouds do not render in Cycles HIP-RT when BVH timesteps != 0

I think I know what the problem is. I'll try to submit a fix by early next week.

Sahar A. Kashi commented on pull request blender/blender#121050 2024-09-03 17:58:20 +02:00
Cycles: Linux Support for HIP-RT

I have a slight lean towards just always requiring the linker since

Originally, HIPCC_EXECUTABLE was required but not HIP_LINKER_EXECUTABLE. At some point, I noticed the linker was no longer…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-09-03 17:00:31 +02:00
Cycles: Linux Support for HIP-RT

I will add this (hiprt not installing any of its headers) to the list of changes I am compiling to hand over to the hiprt team. The project does install some of its headers (in the dist folder)…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-09-03 16:56:23 +02:00
Cycles: Linux Support for HIP-RT

HIP_LINKER_EXECUTABLE which points to clang++ is a HIP component but if it is missing, it only affects enabling HIP-RT. When HIP-RT headers are present, Found HIPRT is appropriate, but if the HIP…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-29 16:18:46 +02:00
Cycles: Linux Support for HIP-RT

Thank you @Sergey I'm glad the PR is now in a reasonable shape. @LazyDodo and @ideasman42 let me know what you think. I will be away until next Tuesday. If there are any concern, I will…

Sahar A. Kashi commented on issue blender/blender#126749 2024-08-28 23:33:04 +02:00
HIP-RT Memory leak in Cycles viewport

Yes, I confirm I can reproduce the issue, and that it is not related to blender/blender#120702

Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-28 19:27:36 +02:00
Cycles: Linux Support for HIP-RT

Not sure it worth going more complicated route

Good! If this option reliably works, then I'd much rather stick with the way it is set up now, rather than splitting the work like I did in the…

Sahar A. Kashi pushed to compilation_break_down at salipour/AMD_HIPRT 2024-08-28 01:38:48 +02:00
aa54a52051 Compiler hiprt kernels per architecture
Sahar A. Kashi pushed to compilation_break_down at salipour/AMD_HIPRT 2024-08-28 00:45:24 +02:00
3f9574a50d Merge branch 'main' into HIPRT_OPEN_SOURCE
bb24677a76 Cleanup: Rename CustomData_copy to CustomData_initi_from.
ea2f40748c Fix #122160: GPv3: Edit mode Undo memory leak.
b61e618886 Cleanup: Remove unused function
9c3eb49f8b Cleanup: Compositor: Generalize naming of shader operations
Compare 10 commits »
Sahar A. Kashi created branch compilation_break_down in salipour/AMD_HIPRT 2024-08-28 00:45:23 +02:00
Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-27 18:14:12 +02:00
Cycles: Linux Support for HIP-RT

Do you mean we can break down the kernel_rt_gfx into individual architectures?

Yes.

Is there a flag we can pass to the HIP compiler to build more things in parallel?

Yes, -parallel-jo…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-27 04:24:16 +02:00
Cycles: Linux Support for HIP-RT

The kernel_rt_gfx.hipfb takes about 30min to compile with rocm 6.1.2 and 6.1.3

More or less the same for me (although I have a very old cpu on my Ubuntu machine.) We can mitigate it by some…