Sahar A. Kashi salipour
2 Followers · 0 Following
  • Joined on 2022-02-10
Repositories
1
 Projects Public Activity Starred Repositories
Sahar A. Kashi approved blender/blender#126788 2024-08-27 04:17:24 +02:00
Fix: Cycles memory leak in HIP-RT
Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-23 23:13:14 +02:00
Cycles: Linux Support for HIP-RT

@Sergey for e4ae1b5533 I did build the dependencies on Rocky 8 and Ubuntu. build Blender with HIP-RT enabled…

Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-08-23 23:02:58 +02:00
1deab0f181 Format
Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-08-21 20:58:43 +02:00
e4ae1b5533 Merge branch 'main' into HIPRT_OPEN_SOURCE
ce82d4434f Fix #126324: Fallback to linear POLY curves for invalid Alembic data
de47fee2e1 Fix #126156: Do not allow to assign embedded IDs to IDProperties.
08d5eb8f9c Cleanup: cmake formatting
83fe5712ab Fix #126525: Gizmo flickering when a Blender window is resized
Compare 246 commits »
Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-08-21 00:40:17 +02:00
e96f124810 Adding back hiprt64.dll copy to cmake file
Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-20 20:18:48 +02:00
Cycles: Linux Support for HIP-RT

Assuming I'll be using ubuntu 22.04 or 24.04 on the test machine, what is the driver version I'd need to have for tests?

@sergey any recent driver should work.

Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-20 20:15:34 +02:00
Cycles: Linux Support for HIP-RT

The error seems to occur because HIPRT_INCLUDE_DIR isn't defined yet (because WITH_CYCLES_DEVICE_HIPRT isn't enabled in this configuration).

Ah! The check for WITH_HIPRT is left behind…

Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-19 19:23:27 +02:00
Cycles: Linux Support for HIP-RT

@Sergey what's the next step? I am waiting for your decision about the bvh binary files.

Sahar A. Kashi commented on issue blender/blender#117567 2024-08-19 18:11:35 +02:00
HIP-RT renders some instanced objects differently from other BVHs

It could be a precision issue with transform matrix. Is there anything special about the scene other than the instanced geometry?

Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-08-16 17:42:27 +02:00
d26529cf17 Merge branch 'HIPRT_OPEN_SOURCE' of projects.blender.org:salipour/AMD_HIPRT into HIPRT_OPEN_SOURCE
8a75c29504 code review update
Compare 2 commits »
Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-16 17:15:44 +02:00
Cycles: Linux Support for HIP-RT

@Sergey please let me know if my previous comments clear up confusion and also let me know how you would like to move forward with BVH binaries (do you want to use my HIP-RT fork?)

Sahar A. Kashi commented on issue blender/blender#120702 2024-08-15 17:40:06 +02:00
Cycles HIP-RT Memory leak

@Alaska, my apologies, in my previous comment, I should have said "the fix will be in the driver." I don't think the driver is yet publicly available.

Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-14 21:05:52 +02:00
Cycles: Linux Support for HIP-RT

@Sergey The explanations for the different parts are scattered across various threads, so I'll do my best to consolidate everything here.

Please remove handling of libhiprt64.so and…

Sahar A. Kashi commented on issue blender/blender#120702 2024-08-14 20:41:16 +02:00
Cycles HIP-RT Memory leak

No need to update the SDK. For upcoming version of Blender, the fix is already in #121050. For previous versions of Blender, the fix is in the driver.

Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-08-13 19:03:58 +02:00
7336078910 Merge branch 'main' into HIPRT_OPEN_SOURCE
2449b12e67 Fix #125929: Add curves creates 1-segment too short curves
a716685f2f Fix #126149: Flat face wireframe edges hidden on some platforms
e1422530d6 Fix: crash when attempting to unload volume tree twice
9eb7e8bfd1 Refactor: Sculpt: Reduce reliance on BVH tree geometry back pointers
Compare 91 commits »
Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-13 03:33:35 +02:00
Cycles: Linux Support for HIP-RT

@Sergey what do you think about the placement of these files? I have them all in the root directory. I have built the dependencies and the app on both Windows and Ubuntu. It is functional with the…

Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-08-13 03:25:32 +02:00
8c17957810 Removed extra slash from path
Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-08-12 23:58:47 +02:00
84649f7e04 adding hiprtlib directory
Sahar A. Kashi pushed to HIPRT_OPEN_SOURCE at salipour/AMD_HIPRT 2024-08-09 20:38:03 +02:00
fa529dcf62 Merge branch 'HIPRT_OPEN_SOURCE' of projects.blender.org:salipour/AMD_HIPRT into HIPRT_OPEN_SOURCE
7358de3ee8 Updated the copy location of bvh kernel binaries
Compare 2 commits »
Sahar A. Kashi commented on pull request blender/blender#121050 2024-08-09 17:48:28 +02:00
Cycles: Linux Support for HIP-RT

@Sergey sorry didn't mean for this change list to get reviewed. I was moving from Linux to Windows so I pushed the changes to pick up on Windows. Should have pushed to a different branch!

That…