• Joined on 2023-03-11
sixthat pushed to main at sixthat/blender 2023-04-17 15:04:56 +02:00
38bf3e1911 I18n: translate default preset name
48979c6cdc Py module i18n utils: return subprocess.run result to catch output of external commands.
e45746591b Metal: Add new files for Storage Buffers support
2a4323c2f5 Mesh: Move edges to a generic attribute
f588a0596b Fix #106943: driver on inactive view layer doesn't work
Compare 664 commits »
sixthat deleted branch remove-unneccessary-vert-pos-copy from sixthat/blender 2023-03-21 15:54:37 +01:00
sixthat commented on pull request blender/blender#105743 2023-03-18 23:20:11 +01:00
Mesh: Set bounds eagerly for spherical and cylindrical primitive nodes

Hey @sixthat, just for reference, are you familiar with the specifics of complexity estimation? If it's not (O = N), but (O = const) then everything is fine (really good).

I am familiar…

sixthat commented on pull request blender/blender#105756 2023-03-18 22:54:15 +01:00
Mesh: Remove unnecessary mesh position copying

Hey, thanks for the updates! Could you merge main into this branch and press "Resolve Conversation" on the comments you addressed?

Sure! main is merged now and I have closed all conversations…

sixthat commented on pull request blender/blender#105743 2023-03-18 22:49:20 +01:00
Mesh: Set bounds eagerly for spherical and cylindrical primitive nodes

In source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cone.cc the eager bounds are immediately invalidated by a translation when they are created by `static void node_geo_exec(GeoNodeExe…

sixthat pushed to remove-unneccessary-vert-pos-copy at sixthat/blender 2023-03-18 22:25:29 +01:00
7a29ce5e6d Merge branch 'main' into remove-unneccessary-vert-pos-copy
335688dd42 EEVEE-Next: Deferred Pipeline
b93a66d603 IO: refactor, replace std::vector with Vector in OBJ and PLY code
1b2f58adff VSE: Update text of text strip after each typed character
bb1c503bee Fix 105824: Retiming remove gizmo size is fixed
Compare 188 commits »
sixthat pushed to main at sixthat/blender 2023-03-18 22:23:02 +01:00
335688dd42 EEVEE-Next: Deferred Pipeline
b93a66d603 IO: refactor, replace std::vector with Vector in OBJ and PLY code
1b2f58adff VSE: Update text of text strip after each typed character
bb1c503bee Fix 105824: Retiming remove gizmo size is fixed
cf8640e7b5 Fix: Broken mesh to curve conversion
Compare 143 commits »
sixthat commented on pull request blender/blender#105756 2023-03-15 22:02:24 +01:00
Mesh: Remove unnecessary mesh position copying

I managed to identify my mistake. The particle_system needed the original vertex positions to stay untouched while computing the deformation. That's why it made a working copy.

Also: I tried to…

sixthat pushed to remove-unneccessary-vert-pos-copy at sixthat/blender 2023-03-15 21:58:15 +01:00
f4f5969e07 Revert changes to particle_system.c
sixthat commented on pull request blender/blender#105756 2023-03-15 11:58:07 +01:00
Mesh: Remove unnecessary mesh position copying

I just found a failing test and I'm going to investigate it now. Didn't see a way to withdraw the review request so I just put this in WIP again.

sixthat commented on issue blender/blender#105551 2023-03-15 11:23:44 +01:00
Eager mesh bounds calculation for primitive nodes

@arevkov Feel free to update your PR with my input! I believe that collaboration is key in these kind of projects and to me it doesn't really matter who pushes the code in the end. Having your…

sixthat pushed to remove-unneccessary-vert-pos-copy at sixthat/blender 2023-03-15 11:08:24 +01:00
0139d95cc8 Revert changes to multires_reshape.cc
04c034b972 Tag changed vertex positions
Compare 2 commits »
sixthat commented on issue blender/blender#105551 2023-03-14 17:02:09 +01:00
Eager mesh bounds calculation for primitive nodes

@arevkov Do you want to go ahead and extend the changes to the cone and spheres as well? I do have solutions for those but perhaps it is better to just do all of them in one PR?

I'll leave my…

sixthat commented on pull request blender/blender#105756 2023-03-14 14:53:16 +01:00
Mesh: Remove unnecessary mesh position copying

Thanks for the feedback! I edited the description. Does this suffice? :)

sixthat pushed to remove-unneccessary-vert-pos-copy at sixthat/blender 2023-03-14 12:03:07 +01:00
176d642e1b Mesh: Remove unneccessary mesh vert copies
sixthat commented on issue blender/blender#103789 2023-03-14 11:44:15 +01:00
Remove unnecessary mesh position copying

There is code where a copy of the vertex positions is actually neccessary and for which BKE_mesh_vert_coords_alloc is used. How are we handling this? Do we have another function for this or do…

sixthat created pull request blender/blender#105756 2023-03-14 11:12:13 +01:00
WIP: Mesh: Remove unnecessary mesh position copying
sixthat created branch remove-unneccessary-vert-pos-copy in sixthat/blender 2023-03-14 10:57:34 +01:00
sixthat pushed to remove-unneccessary-vert-pos-copy at sixthat/blender 2023-03-14 10:57:34 +01:00
4587643a57 Mesh: Remove unneccessary mesh vert copies
sixthat deleted branch remove-unneccessary-vert-pos-copy from sixthat/blender 2023-03-14 10:56:35 +01:00