studio
/
blender-studio-pipeline
10
23
Fork 17
Code Issues 13 Pull Requests 3 Projects Releases 1 Activity

Blender Crawl: During Purge Remove Fake User for Linked Data-Blocks #105

Merged
Nick Alberelli merged 1 commits from Mets/blender-studio-pipeline:better-purge into main 2023-07-12 17:45:18 +02:00
Conversation 0 Commits 1 Files Changed 1 +25 -1
Demeter Dzadik commented 2023-07-10 11:01:35 +02:00
Member
Copy Link

...and collections.

I believe this should be built-in Blender behaviour, but it's already on the devs' radar, and in the meantime we have a production that will need to be cleaned up soon.

To explain a bit better, here's what can happen sometimes:

  • You have an ID with a fake user in an asset (usually a collection)
  • You link the asset to a shot
  • You change your mind, and don't want the asset in the shot anymore; You might Un-link it from the Scene instead of "Delete Hierarchy".
  • Now its collections have no real users left
  • You run Purge and expect it to go away from the file
  • It does not, because it has a fake user flag.

Even though obviously that fake user flag's intention was to keep the ID in the original file, not when it gets linked in somewhere else. Not to mention that people don't realize that Collections have the fake user flag set to True by default, since it's not visible anywhere.

Tested on Pets shots 50_70, 50_80, 50_90, 50_100.

...and collections. I believe this should be built-in Blender behaviour, but it's already on the [devs' radar](https://projects.blender.org/blender/blender/issues/106321), and in the meantime we have a production that will need to be cleaned up soon. To explain a bit better, here's what can happen sometimes: - You have an ID with a fake user in an asset (usually a collection) - You link the asset to a shot - You change your mind, and don't want the asset in the shot anymore; You might Un-link it from the Scene instead of "Delete Hierarchy". - Now its collections have no real users left - You run Purge and expect it to go away from the file - It does not, because it has a fake user flag. Even though obviously that fake user flag's intention was to keep the ID in the **original** file, not when it gets linked in somewhere else. Not to mention that people don't realize that Collections have the fake user flag set to True by default, since it's not visible *anywhere*. Tested on Pets shots 50_70, 50_80, 50_90, 50_100.
Demeter Dzadik added 1 commit 2023-07-10 11:01:39 +02:00
Nick Alberelli changed title from Blender Purge: use_fake_user=False for linked IDs to Blender Crawl: use_fake_user=False for linked IDs 2023-07-10 22:20:56 +02:00
Nick Alberelli changed title from Blender Crawl: use_fake_user=False for linked IDs to Blender Crawl: Remove Fake User for Linked Data-Blocks 2023-07-12 17:44:03 +02:00
Nick Alberelli changed title from Blender Crawl: Remove Fake User for Linked Data-Blocks to Blender Crawl: During Purge Remove Fake User for Linked Data-Blocks 2023-07-12 17:44:16 +02:00
Nick Alberelli merged commit 72742525a0 into main 2023-07-12 17:45:18 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-pipeline#105
No description provided.
Delete Branch "Mets/blender-studio-pipeline:better-purge"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?