studio/blender-studio-pipeline
13
29
Fork 18
Code Issues 17 Pull Requests 4 Projects Releases 1 Activity

Blender Kitsu: Fix Frame Range Warning #126

Closed
Nick Alberelli wants to merge 6 commits from (deleted):fix/frame-range-warning into main
pull from: (deleted):fix/frame-range-warning
merge into: studio:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 6 Files Changed 4 +63 -58
Nick Alberelli commented 2023-07-14 23:13:15 +02:00
Member
Copy Link

Closes: #113

What's Changed?

  • If no Kitsu Context is detected, a prominent warning is shown
  • If Frame Range is out of date, a prominent warning will appear
  • Pull Frame Range icon is updated to arrow down
  • Frame Range warning will be displayed even if no Kitsu Context is found

Kitsu Context Warning

image

Frame Range Warning Demo

frame_range_warning

Important Considerations

This PR changes the way Frame Range is checked, instead of only checking at file load, we are now checking anytime the Kitsu panel is displayed, using a custom getter on a BoolProperty. I am relying on Blender Kitsu's cache to access about the active shot. It is important to consider the slightly increases the overhead of the addon, but it may be worth it to give "LIVE" warnings to the users.

Closes: https://projects.blender.org/studio/blender-studio-pipeline/issues/113 ## What's Changed? - If no Kitsu Context is detected, a prominent warning is shown - If Frame Range is out of date, a prominent warning will appear - Pull Frame Range icon is updated to arrow down - Frame Range warning will be displayed even if no Kitsu Context is found ### Kitsu Context Warning ![image](/attachments/5369154b-c4c4-4f85-89bc-01eb9d3375a9) ### Frame Range Warning Demo ![frame_range_warning](/attachments/744ec994-8742-4b8b-b5ad-8d44dc7dd98d) ## Important Considerations This PR changes the way Frame Range is checked, instead of only checking at file load, we are now checking anytime the Kitsu panel is displayed, using a custom getter on a BoolProperty. I am relying on Blender Kitsu's cache to access about the active shot. It is important to consider the slightly increases the overhead of the addon, but it may be worth it to give "LIVE" warnings to the users.
image.png
54 KiB
frame_range_warning.gif
1.4 MiB
image.png
137 KiB
frame_range_warning.gif
1.7 MiB
image.png frame_range_warning.gif
Nick Alberelli added 6 commits 2023-07-14 23:13:17 +02:00 
- Make warning more aggressive (red)
 - Warning is based on property instead of post load so it always checks file state
Nick Alberelli changed title from Blender Kitsu: Fix Frame Range Warning so it is persistent to Blender Kitsu: Fix Frame Range Warning 2023-07-14 23:13:33 +02:00
Simon Thommes commented 2023-07-17 10:27:29 +02:00
Member
Copy Link

I mean, this does help a bit, but the main issue is that in lighting file we don't really need the kitsu addon for anything, other than setting the output to final quality. So throughout the lighting process there is never the need to look at the kitsu panel.
Ideally an out-of-date frame range would pop up a warning regardless of that.

As for the context not being correct. It's only really necessary for the frame range, as we don't need other tools in there currently. But in theory I don't see a reason why it would ever fail, as the file structure is very much rigid and clear. The shot builder manages to create files in the right places just fine. So that should just be improved to work better automatically. And if it didn't work show a pop-up to be able to check the frame range.
In most cases the context should probably already be set by the shot builder when the file is created.

I mean, this does help a bit, but the main issue is that in lighting file we don't really need the kitsu addon for anything, other than setting the output to final quality. So throughout the lighting process there is never the need to look at the kitsu panel. Ideally an out-of-date frame range would pop up a warning regardless of that. As for the context not being correct. It's only really necessary for the frame range, as we don't need other tools in there currently. But in theory I don't see a reason why it would ever fail, as the file structure is very much rigid and clear. The shot builder manages to create files in the right places just fine. So that should just be improved to work better automatically. And if it didn't work show a pop-up to be able to check the frame range. In most cases the context should probably already be set by the shot builder when the file is created.
👍 1
Nick Alberelli commented 2023-07-17 15:00:48 +02:00
Author
Member
Copy Link

@SimonThommes @eyecandy

Ok I understand, so lets go a head and scrap this PR, instead I will make a new PR just focusing on a pop up when the frame range is incorrect on file load.

@SimonThommes @eyecandy Ok I understand, so lets go a head and scrap this PR, instead I will make a new PR just focusing on a pop up when the frame range is incorrect on file load.
Simon Thommes commented 2023-07-17 15:09:14 +02:00
Member
Copy Link

Sorry that the whole issue wasn't clear from the beginning!

I don't necessarily think this PR needs to be scrapped, It might make sense to have those solutions coexist, just in case we run into a situation, where the popup was dismissed improperly or didn't appear for some reason.

Sorry that the whole issue wasn't clear from the beginning! I don't necessarily think this PR needs to be scrapped, It might make sense to have those solutions coexist, just in case we run into a situation, where the popup was dismissed improperly or didn't appear for some reason.
👍 1
Nick Alberelli commented 2023-07-18 16:19:00 +02:00
Author
Member
Copy Link

Replaced by: #128

Replaced by: https://projects.blender.org/studio/blender-studio-pipeline/pulls/128
Nick Alberelli closed this pull request 2023-07-18 16:19:01 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-pipeline#126
No description provided.
Delete Branch "(deleted):fix/frame-range-warning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?