studio
/
blender-studio-pipeline
10
24
Fork 18
Code Issues 10 Pull Requests 3 Projects Releases 1 Activity

Blender Kitsu: Add Frame Range Pop-up #128

Merged
Nick Alberelli merged 18 commits from :fix/frame-range-popup into main 2023-07-19 17:32:39 +02:00
Conversation 5 Commits 18 Files Changed 3 +120 -54
Nick Alberelli commented 2023-07-18 16:18:31 +02:00
Member
Copy Link

Closes: #113

What's Changed

  • Pop up if Frame Range is incorrect
  • Pull Frame Range operator is red if there is an error
  • Pull Frame Range operator icon is changed to arrow down
  • Refactored Frame Range Calculation for Pull/Push and Load_Post_Handler
  • Add Check Frame Range Operator (to be used in #124)

frame_range_warning

TODO

  • add some more text with more information
Closes: https://projects.blender.org/studio/blender-studio-pipeline/issues/113 ## What's Changed - Pop up if Frame Range is incorrect - Pull Frame Range operator is red if there is an error - Pull Frame Range operator icon is changed to arrow down - Refactored Frame Range Calculation for Pull/Push and Load_Post_Handler - Add Check Frame Range Operator (to be used in https://projects.blender.org/studio/blender-studio-pipeline/pulls/124) ![frame_range_warning](/attachments/4ee21a51-4475-4ce5-a348-30346970e603) ## TODO - [x] add some more text with more information
frame_range_warning.gif
1.3 MiB
Simon Thommes commented 2023-07-18 16:28:18 +02:00
Member
Copy Link

Great, that should make it a lot harder to miss!

I think it's generally fine that the popup disappears when the mouse is moved off it, but it would be nice if it was larger then. Could add some more text with more information, like how the frame range changed to create a larger popup.

Great, that should make it a lot harder to miss! I think it's generally fine that the popup disappears when the mouse is moved off it, but it would be nice if it was larger then. Could add some more text with more information, like how the frame range changed to create a larger popup.
👍 1
Nick Alberelli commented 2023-07-18 16:46:47 +02:00
Author
Member
Copy Link

@SimonThommes I have updated the warning to be larger like we discussed

image

@SimonThommes I have updated the warning to be larger like we discussed ![image](/attachments/782c0c24-8fb0-4d42-a8dd-c1d4833288a7)
image.png
489 KiB
👍 2 🎉 1
Nick Alberelli force-pushed fix/frame-range-popup from 643fce09fb to feb7660cbc 2023-07-18 22:39:05 +02:00 Compare
Andy Goralczyk commented 2023-07-19 11:34:31 +02:00
Member
Copy Link

this looks great!

this looks great!
❤️ 1
Nick Alberelli commented 2023-07-19 15:43:02 +02:00
Author
Member
Copy Link

One Issue I have discovered in testing is that this pop up now appears on every file. We want the pop up to appear even if there is no kitsu context present, so skipping that requirement means even a basic start-up file opens with the frame range warning.

I am looking into a way to fix this. I am thinking of filtering by directory based on the project root set in the add-on's preferences.

image

One Issue I have discovered in testing is that this pop up now appears on every file. We want the pop up to appear even if there is no kitsu context present, so skipping that requirement means even a basic start-up file opens with the frame range warning. I am looking into a way to fix this. I am thinking of filtering by directory based on the project root set in the add-on's preferences. ![image](/attachments/8d60817b-5ade-4f14-b51c-6f253c59992c)
image.png
601 KiB
Nick Alberelli commented 2023-07-19 16:32:00 +02:00
Author
Member
Copy Link

Update:

Had a discussion with @SimonThommes about the above issue I commented. The decision is to only show this pop-up when the Kitsu context can be determined, to limit the scope of this PR.

I have resolved the comment with this commmit 64ce7254da which will only render the pop-up if the active shot is detected. This PR is ready to be merged.

Looking forward I have opened a new issue specifically for files that need a frame range warning but for some reason the Kitsu Context was not detected. #130

Update: Had a discussion with @SimonThommes about the above issue I [commented](https://projects.blender.org/studio/blender-studio-pipeline/pulls/128#issuecomment-982752). The decision is to only show this pop-up when the Kitsu context can be determined, to limit the scope of this PR. I have resolved the comment with this commmit https://projects.blender.org/studio/blender-studio-pipeline/commit/64ce7254daa176ac8175631769be262a689b3a43 which will only render the pop-up if the active shot is detected. This PR is ready to be merged. Looking forward I have opened a new issue specifically for files that need a frame range warning but for some reason the Kitsu Context was not detected. https://projects.blender.org/studio/blender-studio-pipeline/issues/130
Nick Alberelli force-pushed fix/frame-range-popup from 64ce7254da to a106ea75c8 2023-07-19 16:33:44 +02:00 Compare
Nick Alberelli force-pushed fix/frame-range-popup from a106ea75c8 to b8fde09058 2023-07-19 17:20:39 +02:00 Compare
Nick Alberelli merged commit 8a5a8c80c1 into main 2023-07-19 17:32:39 +02:00
Nick Alberelli deleted branch fix/frame-range-popup 2023-07-19 17:32:40 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-pipeline#128
No description provided.
Delete Branch ":fix/frame-range-popup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?