studio/blender-studio-pipeline
13
29
Fork 18
Code Issues 17 Pull Requests 4 Projects Releases 1 Activity

Blender Kitsu: Update Render Review GPU shader code to new syntax that works on Metal #305

Merged
Sebastian Parborg merged 1 commits from tone-watson/blender-studio-pipeline:bugfix/rr-gpu-shader into main 2024-06-04 16:14:13 +02:00
Conversation 3 Commits 1 Files Changed 1 +20 -32
tone-watson commented 2024-05-30 20:41:14 +02:00
Contributor
Copy Link

Discussed in #290

I applied a similar change to 2643f1a98b

I tested this in the latest release where render_review is its own addon, I don't have a setup to test the latest code from main at the moment

Discussed in https://projects.blender.org/studio/blender-studio-pipeline/issues/290 I applied a similar change to https://projects.blender.org/studio/blender-studio-pipeline/commit/2643f1a98ba288055aea4ae43644457a9c331d48 I tested this in the latest release where `render_review` is its own addon, I don't have a setup to test the latest code from `main` at the moment
tone-watson added 1 commit 2024-05-30 20:41:16 +02:00
tone-watson force-pushed bugfix/rr-gpu-shader from e85af0e0fc to 59033eb7f2 2024-05-31 06:12:00 +02:00 Compare
Nick Alberelli commented 2024-05-31 16:38:49 +02:00
Member
Copy Link

@ZedDB @fsiddi can either of you test this on mac os?

@ZedDB @fsiddi can either of you test this on mac os?
Nick Alberelli changed title from Apply similar changes from "Fix #290: Update GPU shader code to new syntax that works on Metal" to scripts-blender/addons/blender_kitsu/render_review/draw.py to Blender Kitsu: Update Render Review GPU shader code to new syntax that works on Metal 2024-05-31 16:54:39 +02:00
Nick Alberelli commented 2024-05-31 16:58:16 +02:00
Member
Copy Link

A change like this should also be applied to Sequence Draw.py would make sense if we took this oppritunity to centralize this drawing code. That is one aspect I didn't de-duplicate when I completed #296

A change like this should also be applied to [Sequence Draw.py](https://projects.blender.org/studio/blender-studio-pipeline/src/branch/main/scripts-blender/addons/blender_kitsu/sqe/draw.py) would make sense if we took this oppritunity to centralize this drawing code. That is one aspect I didn't de-duplicate when I completed https://projects.blender.org/studio/blender-studio-pipeline/pulls/296
Sebastian Parborg commented 2024-06-04 16:12:58 +02:00
Member
Copy Link

Seems to work fine for me!

A change like this should also be applied to Sequence Draw.py would make sense if we took this oppritunity to centralize this drawing code. That is one aspect I didn't de-duplicate when I completed #296

That code is already using the new API, so we shouldn't need update that code as it should already work on Mac with the Metal backend.

Seems to work fine for me! > A change like this should also be applied to [Sequence Draw.py](https://projects.blender.org/studio/blender-studio-pipeline/src/branch/main/scripts-blender/addons/blender_kitsu/sqe/draw.py) would make sense if we took this oppritunity to centralize this drawing code. That is one aspect I didn't de-duplicate when I completed https://projects.blender.org/studio/blender-studio-pipeline/pulls/296 That code is already using the new API, so we shouldn't need update that code as it should already work on Mac with the Metal backend.
Sebastian Parborg merged commit 0f3fcf57d3 into main 2024-06-04 16:14:13 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-pipeline#305
No description provided.
Delete Branch "tone-watson/blender-studio-pipeline:bugfix/rr-gpu-shader"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?