studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

[Blender_Kitsu] Shot_Builder fix lighting task type #9

Merged
Nick Alberelli merged 2 commits from :fix/lighting-task-type into master 2023-04-17 19:09:07 +02:00
Conversation 0 Commits 2 Files Changed 1 +18 -10
Nick Alberelli commented 2023-04-17 14:56:58 +02:00
Member
Copy Link

Closes: TinyNick/blender-studio-tools#31

Issue

After setup of #5 some steps meant only for animation tasks are being run on all tasks

Solution

Run the following steps only if task type is animation. I wanted to tackle this during a refactor #6 so in the meantime I have done a quick solution and added #TODO comments where relevant to improve the code during refactor.

What's Changed

Following Steps are skipped if task is not anim

  • Check if Editorial Export path is valid
  • Setup animaton workspace
  • Import Editorial reference
  • Add VSE Area for reference

Demo

In this demo I am comparing an animation task type to a lighting task type.

image

Closes: https://projects.blender.org/TinyNick/blender-studio-tools/issues/31 # Issue After setup of https://projects.blender.org/studio/blender-studio-tools/pulls/5 some steps meant only for animation tasks are being run on all tasks # Solution Run the following steps only if task type is animation. I wanted to tackle this during a refactor https://projects.blender.org/studio/blender-studio-tools/pulls/6 so in the meantime I have done a quick solution and added #TODO comments where relevant to improve the code during refactor. ## What's Changed ### Following Steps are skipped if task is not anim - Check if Editorial Export path is valid - Setup animaton workspace - Import Editorial reference - Add VSE Area for reference # Demo In this demo I am comparing an animation task type to a lighting task type. ![image](/attachments/8db10e4d-0874-4ad9-b0d2-78f48577d79b)
image.png
202 KiB
Nick Alberelli changed title from WIP: [Blender_Kitsu] Shot_Builder fix lighting task type to [Blender_Kitsu] Shot_Builder fix lighting task type 2023-04-17 15:17:46 +02:00
Nick Alberelli force-pushed fix/lighting-task-type from a4cab27c67 to 037577588d 2023-04-17 19:08:02 +02:00 Compare
Nick Alberelli merged commit cb709e9943 into master 2023-04-17 19:09:07 +02:00
Nick Alberelli deleted branch fix/lighting-task-type 2023-04-17 19:09:08 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#9
No description provided.
Delete Branch ":fix/lighting-task-type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?