Move Anim_Setup module into Blender_Kitsu #5

Nick Alberelli · 2023-04-04T20:14:46+02:00

Nick Alberelli commented

2023-04-04 20:14:46 +02:00

Closes: TinyNick/blender-studio-tools#10

Issue

Several functions within Anim_Setup module should be automatically run during shot_builder process. This was requested by several people in the studio.

Whats Changed?

Load Shot data from central Blender_Kitsu.Gazu module
Load latest Editorial Export into VSE and shift strips to correct time
- Allow user to offset this video with integer in preferences
Setup Workspaces for Animation
Create Action with Fake user on all Armatures (based on naming conventions)
Set correct Frame Range per Kitsu Shot data
Allow User to run python commands after running shot_builder
Add VSE to Animation Workspace to show user Editorial Export
Save File only at the end of the operation

Features Skipped from Anim_Setup Module

~~- [ ] Import camera action from the previs file~~
~~- [ ] Import actions for found assets from previs file~~
~~- [ ] Shift animation of camera and asset actions to start at layout cut in~~

Features skipped because they rely on a previz.blend file that doesn't exist in the studio anymore. Shots are arranged with camera markers with is another legacy feature.

Notes

This merge focuses add the additional automation steps to Blender_Kitsu's shot_builder. These are steps requested by users in the studio, and should be done soon. It does not re-factor or change the prexisting logic of the shot_builder. A refactor will be necessary to make this operator more streamlined. TinyNick/blender-studio-tools#26

Closes: https://projects.blender.org/TinyNick/blender-studio-tools/issues/10 # Issue Several functions within Anim_Setup module should be automatically run during shot_builder process. This was requested by several people in the studio. # Whats Changed? - Load Shot data from central Blender_Kitsu.Gazu module - Load latest Editorial Export into VSE and shift strips to correct time - Allow user to offset this video with integer in preferences - Setup Workspaces for Animation - Create Action with Fake user on all Armatures (based on naming conventions) - Set correct Frame Range per Kitsu Shot data - Allow User to run python commands after running shot_builder - Add VSE to Animation Workspace to show user Editorial Export - Save File only at the end of the operation # Features Skipped from [Anim_Setup](https://projects.blender.org/TinyNick/blender-studio-tools/commits/branch/master/anim_setup) Module ~~- [ ] Import camera action from the previs file~~ ~~- [ ] Import actions for found assets from previs file~~ ~~- [ ] Shift animation of camera and asset actions to start at layout cut in~~ *Features skipped because they rely on a previz.blend file that doesn't exist in the studio anymore. Shots are arranged with camera markers with is another legacy feature.* ### Notes This merge focuses add the additional automation steps to Blender_Kitsu's shot_builder. These are steps requested by users in the studio, and should be done soon. It does not re-factor or change the prexisting logic of the shot_builder. A refactor will be necessary to make this operator more streamlined. https://projects.blender.org/TinyNick/blender-studio-tools/issues/26

Nick Alberelli added 26 commits 2023-04-04 20:14:48 +02:00

Intial Commit 4e2040505e

- Move Shot_builder into Blender_Kitsu
 - Changes from older branch

Merge branch 'feature/merge_shot_builder_into_blender_kitsu' into develop b2aeefcc50

[Blender_Kits] Use Anim_Setup 'Setup Workspaces' 853bf6d303

- add operator file
- add registration to __init__.py

[Blender_Kitsu] Import video from editorial folder 50819b1535

- Adds storyboard ref from editorial inside scene
- Re-use logic from anim_setup
- import video from editorial folder during shot_build

[Blender_Kitsu] Update 'edit_export_dir' Property a5fed16d82

- rename to 'Editorial Export Directory'
 - add description with hint to current editorial export path

[Blender_Kitsu] Set Actions on Armatures c996cf3a20

- Find all Armature Objects
- Set Action name to match blender-studio convention
- Set action to fake user

[Blender Kitsu] Set Frame Range during Shot Build ffff5b5ad7

[Blender_Kitsu] Load Editoral Export Path Safely b46156f636

- add edit_export_file_pattern to prefs
 - expose file pattern in addon preferences
 - check is_editorial_dir_valid() with function to prefs
 - Cancel shot_builder if edit_export_dir or edit_export_file_pattern is invalid

[Blender Kitsu] Expose frame offset in addon prefs d5746a6316

- Clear "TODO EXPOSE INT IN ADDON PREFERENCES"
 - Move shot_builder addon prefs above misc
 - Expose Start Frame Offset in addon pref
 - Nest Start Frame under 'show advanced'
 - Set frame range via ''shot_builder_frame_offset"

[Blender_Kitsu] Expose Armature naming convention in addon prefs 6fc39c1a5f

- expose armature prefix as string in addon pref
 - expose action prefix as string in addon pref
 - give both detailed descriptions
 - use above string props in shot_builder; intilize armatures

[Blender_Kitsu] Nest anim_setup in Shot_builder 3b7e20091e

- Move anim_setup module to shot_builder
 - Refactor anim_setup functions into core functions that are called by operators, to easily re-use functions in shot_builder
 - Warn user before execution if editorial export directory is invalid (don't used prop update) use @property decorator instead
 - Centralize logic to check if path is valid in anim_setup module
 - remove duplicate code
 - replace bpy.ops.anim_setup with new function calls in shot_builder
 - use frame offset in editorial_export_get_latest
 - only report if workspace was deleted once in `ANIM_SETUP_OT_setup_workspaces`

[Blender Kitsu] add VSE area to animation workspace WIP 8bc00a44b2

- Add animation_workspace_vse_area_add() function
- Comment out function call in operator
- Add TODO to fix UI dependant call

[Blender Kitsu] Fix 'add vse area' by making operator modal eaafcb5644

- main shot_builder function to modal

[Blender_Kitsu] move sequence strip, restore logic 6829a61ea4

- restore original formula to offset sequence strip
- restore original variables to offset sequence strip

[Blender_Kitsu] create editorial sub-module f1f815a648

- move functions related to importing references into editorial module from the anim_setup module
- nest editorial under shot_builder module

[Blender_Kitsu] Editorial: improve error messages 44cb913195

- move report outside of core function
- return none if no shot is found but server is connected

[Blender_Kitsu] anim_setup improve error messages 2376381b28

[Blender_Kitsu] Improve Shot_Builder op and add success message 1175584c49

[Blender_Kitsu] Shot Builder, save only at end of operation 2e58de49c2

- don't save in the middle of the function call
- extract save logic and move to main operator
- build gazu context manually without relying on file path context
- use gazu.shot in editorial standalone operator
- reorganize main operator

[Blender_Kitsu] Improve file_Save feedback for shot_builder 6fe881e3a6

- Add option to skip save
 - Add feedback if file already exists error
 - Move logic back to save_fily.py and make it callable from other functions

[Blender_Kistsu] shot_builder allow user to supply commands to execute b23172c9c2

- create text box that user can supply commands into incase there is customization for the production to be done

[Blender Kitsu] Fix File Save durign Shot_build 6e32f66e8b

[Blender_Kitsu] Clean Whitespace in anim_setup module 26c89e3ef8

[Blender_Kitsu] Editorial, remove no-op code 3249cc86d1

[Blender_Kitsu] Allow user to offset editorial reference f17de25a56

- Create Editorial Export Offset property
 - Use property when placing VSE reference
 - Expose Property in UI

Merge Master into Blender_Kitsu: 85dba24d3a

commit f85db92325
Author: Nick Alberelli <tinynick@noreply.localhost>
Date:   Tue Apr 4 16:43:32 2023 +0200

    Move Shot Builder into Blender Kitsu

    Closes: TinyNick/blender-studio-tools#2

    The goal of this merge is to re-use to 'Blender Kitsu' addon's gazu based login/api functions in the 'shot builder' addon.

    **What's Changed**
     - Move Shot_builder files to Blender Kitsu Addon
     - Remove Legacy Shot_builder preferences
     - Move Shot_builder properties into Blender Kitsu
     - Use Gazu within shot_builder's kitsu connector
     - Restore Shot Builder Documentation

    Co-authored-by: TinyNick <nick@blender.org>
    Reviewed-on: #3

commit cbfc016ea3
Author: Demeter Dzadik <demeter@blender.org>
Date:   Tue Apr 4 15:37:42 2023 +0200

    AP: reset_armature_pose() now resets booleans

commit 4568ed7f35
Author: Demeter Dzadik <demeter@blender.org>
Date:   Tue Apr 4 15:36:41 2023 +0200

    AssetPipeline: Nudge GeoNode modifiers

    This is necessary because without it, sometimes GeoNode modifier
    inputs just disappear...