bsdf_microfacet.h
fresnel_dielectric()
bsdf_microfacet.h
for better readability
bsdf_microfacet.h
bsdf_microfacet_sample()
for better readability
fresnel_dielectric()
label
at the end of bsdf_microfacet_sample()
Suggestion to the description is irrelevant to the original bug report. Since the reported bug is solved, this issue should be closed.
I don't think scattering would be a problem (do we want anisotropy or not?) but internal blocks might be, so I want to figure out how to do nested dielectrics first. 12% seems a lot to me.
Hi, I committed the fix in fedeaab30f, thanks for investigating.
Hi, the problem is that the new Hair BSDF requires the curve normal for elliptical cross-sections, which is only available when the hair geometry is created via Curve->Empty Hair or Curve->Fur,…
bsdf_sample()
and bsdf_eval()
Turns out that the excessive noise is because I enabled path guiding. Without path guiding both are much less noisy. The 12% overhead because of the extra volume closure seems expected though.
Maybe once grouping and separators are added to nodes, the Principled BSDF could have a "Transmission" group with "Depth" as one of the options? I think this is a good idea. “At Distance”…