Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang pushed to fix-nan-importance at weizhen/blender 2023-08-23 15:40:41 +02:00
5eedff0adf Also cover cases when NaN is not caused by invalid normals
a05a67b6a1 Fix illegal address error in Cycles Light Tree when no emitter is selected
45f3426559 Fix: UserDef_Experimental padding
85b02b893a Workbench-Next: Enabled by default
d732478574 Cleanup: Geometry Nodes: Unnecessary components to check
Compare 6 commits »
Weizhen Huang created pull request blender/blender#111428 2023-08-23 13:36:25 +02:00
Fix illegal address error in Cycles Light Tree when no emitter is selected
Weizhen Huang pushed to fix-nan-importance at weizhen/blender 2023-08-23 13:35:32 +02:00
9423c65b49 Fix illegal address error in Cycles Light Tree when no emitter is selected
3cd14df7d8 Revert "Fix illegal address error in Cycles Light Tree when no emitter is selected"
beaf4854b1 Fix #110328: Clay Strip symmetry does not mirror rotation
7bb693581f UI: Move asset shelf out of experimental
206ab6437b Fix illegal address error in Cycles Light Tree when no emitter is selected
Compare 10 commits »
Weizhen Huang created branch fix-nan-importance in weizhen/blender 2023-08-23 13:35:32 +02:00
Weizhen Huang pushed to main at blender/blender 2023-08-23 12:44:35 +02:00
3cd14df7d8 Revert "Fix illegal address error in Cycles Light Tree when no emitter is selected"
Weizhen Huang pushed to main at blender/blender 2023-08-23 11:54:28 +02:00
206ab6437b Fix illegal address error in Cycles Light Tree when no emitter is selected
Weizhen Huang merged pull request blender/blender#111292 2023-08-23 11:54:28 +02:00
Cycles Light Tree: Add case for when an emitter is not selected
Weizhen Huang approved blender/blender#111292 2023-08-23 11:52:10 +02:00
Cycles Light Tree: Add case for when an emitter is not selected

You are right, if the normal is wrong it's still visible as an artefact, this patch is just to cover illegal address error, so I think it's fine. Thanks!

Weizhen Huang commented on pull request blender/blender#111310 2023-08-22 14:39:53 +02:00
Camera: Move panoramic projection settings to DNA

After adding version bump (0e5639d00305f3da695796827a50322e484a4c3c), when I save a file using this patch, then open it in an older version and try to overwrite the file, I get either `terminated…

Weizhen Huang commented on pull request blender/blender#111292 2023-08-22 10:31:31 +02:00
Cycles Light Tree: Add case for when an emitter is not selected

Is this still needed after #111294 is merged? I am expecting light_tree_cluster_select_emitter() to pick an emitter if there is one, unless all emitters in the cluster have zero importance[0].…

Weizhen Huang pushed to blender-camear-panoramic-parameters at fclem/blender 2023-08-22 09:48:43 +02:00
0c80b6b5c2 Merge branch 'main' into blender-camear-panoramic-parameters
8bae4427ed Fix #111238: Arrow keys in some menus work in the opposite direction
7d688edbd3 Fix tool-tip memory leak
f58d596c36 GHOST/Wayland: print the exception message on failure
920271da42 Keymap: Left and Right Click consistency improvements
Compare 37 commits »
Weizhen Huang commented on pull request blender/blender#111310 2023-08-21 12:41:17 +02:00
Camera: Move panoramic projection settings to DNA

There should be a f suffix.

Weizhen Huang commented on pull request blender/blender#111310 2023-08-21 12:41:17 +02:00
Camera: Move panoramic projection settings to DNA

I think it's not enough to do versioning for ccam. If there is a camera in the scene, but the render engine is not Cycles (as in the default file), then after changing to Cycles all the camera parameters in panoramic type are zero instead of the default values.

Weizhen Huang commented on pull request blender/blender#111310 2023-08-21 12:41:16 +02:00
Camera: Move panoramic projection settings to DNA

These types don't match

Weizhen Huang deleted branch default-multi-ggx from weizhen/blender 2023-08-18 15:51:39 +02:00
Weizhen Huang pushed to main at blender/blender 2023-08-18 15:51:38 +02:00
8367167626 Render: default roughness distribution to Multiscatter GGX
Weizhen Huang merged pull request blender/blender#111267 2023-08-18 15:51:38 +02:00
Render: default roughness distribution to Multiscatter GGX