BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Fix instances update when parent object is changed #33

Merged
Bogdan Nagirniak merged 3 commits from BLEN-394 into hydra-render 2023-05-03 21:18:52 +02:00
Conversation 0 Commits 3 Files Changed 5 +28 -7
Bogdan Nagirniak commented 2023-05-01 07:35:18 +02:00
Owner
Copy Link

Purpose

Changing parent object for mesh doesn't influence to instancer, when parent object is instancer.

Technical steps

  1. Added MeshData::parent_ field for checking parent object changes.
  2. Implemented InstancerData::update_as_parent() and call it when parent is changed.
  3. Fixed bug with positioning instance mesh after update.
### Purpose Changing parent object for mesh doesn't influence to instancer, when parent object is instancer. ### Technical steps 1. Added `MeshData::parent_` field for checking parent object changes. 2. Implemented `InstancerData::update_as_parent()` and call it when parent is changed. 3. Fixed bug with positioning instance mesh after update.
Bogdan Nagirniak self-assigned this 2023-05-01 07:35:18 +02:00
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-05-01 07:35:18 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-05-01 07:35:18 +02:00
Bogdan Nagirniak added 3 commits 2023-05-01 07:35:34 +02:00 
Fixed transform for instance object.
Added check of parent object change.
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-05-01 07:35:53 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-05-01 07:35:53 +02:00
Georgiy Markelov approved these changes 2023-05-02 18:06:48 +02:00
Brian Savery (AMD) approved these changes 2023-05-03 18:50:41 +02:00
Bogdan Nagirniak merged commit 00048d5054 into hydra-render 2023-05-03 21:18:52 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Bogdan Nagirniak
Brian Savery (AMD)
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#33
No description provided.
Delete Branch "BLEN-394"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?