BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Create possibility to provide render settings via BlenderSceneDelegate #41

Merged
Bogdan Nagirniak merged 10 commits from BLEN-349 into hydra-render 2023-05-19 20:19:17 +02:00
Conversation 0 Commits 10 Files Changed 17 +254 -213
Bogdan Nagirniak commented 2023-05-15 20:30:18 +02:00
Owner
Copy Link

Purpose

Hydra render addons could provide additional settings for BlenderSceneDelegate, like HdRPR could ask for direct MaterialXFilename.

Technical steps

  1. Separated setting render and sync settings in Engine: added Engine::set_sync_setting(), Engine::set_render_setting(). Added corresponded functions to python.cc and bpy_hydra.py.
  2. Added possibility to provide additional settings for BlenderSceneDelegate: BlenderSceneDelegate::set_setting().
  3. Separated MaterialData::init() to export_mtlx() and write_material_network_map().
  4. Adjusted code.
### Purpose Hydra render addons could provide additional settings for `BlenderSceneDelegate`, like HdRPR could ask for direct `MaterialXFilename`. ### Technical steps 1. Separated setting render and sync settings in `Engine`: added `Engine::set_sync_setting(), Engine::set_render_setting()`. Added corresponded functions to `python.cc` and `bpy_hydra.py`. 2. Added possibility to provide additional settings for `BlenderSceneDelegate`: `BlenderSceneDelegate::set_setting()`. 3. Separated `MaterialData::init()` to `export_mtlx()` and `write_material_network_map()`. 4. Adjusted code.
Bogdan Nagirniak added 7 commits 2023-05-15 20:30:36 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-05-15 20:30:46 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-05-15 20:30:46 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-05-15 20:30:46 +02:00
Bogdan Nagirniak added 2 commits 2023-05-16 15:04:12 +02:00
Georgiy Markelov approved these changes 2023-05-17 20:35:01 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Tested. Works fine.

Tested. Works fine.
scripts/modules/bpy_hydra.py
@ -22,3 +22,3 @@
bpy_hydra.register_plugins(["/path/to/plugin")])
def get_delegate_settings(self, engine_type):
def get_sync_settings(self, engine_type):
Georgiy Markelov commented 2023-05-17 20:34:50 +02:00
Collaborator
Copy Link

Consider to add a note that these settings refer to keys that Hydra asks.

Consider to add a note that these settings refer to keys that Hydra asks.
👍 1
source/blender/render/hydra/preview_engine.h
@ -22,3 +16,3 @@
private:
/* Singleton class instance */
using FinalEngine::FinalEngine;
Georgiy Markelov commented 2023-05-17 20:12:52 +02:00
Collaborator
Copy Link

Why did you move it here?

Why did you move it here?
Bogdan Nagirniak commented 2023-05-18 09:11:28 +02:00
Author
Owner
Copy Link

PreviewEngine should be created via PreviewEngine::create() therefore constructor moved to private section.

`PreviewEngine` should be created via `PreviewEngine::create()` therefore constructor moved to private section.
Brian Savery (AMD) requested changes 2023-05-18 00:39:31 +02:00
scripts/modules/bpy_hydra.py Outdated
@ -74,3 +80,3 @@
pass
def get_delegate_settings(self, engine_type):
def get_sync_settings(self, engine_type):
Brian Savery (AMD) commented 2023-05-18 00:39:27 +02:00
Collaborator
Copy Link

We need explanations of how these methods should be used / overridden

We need explanations of how these methods should be used / overridden
Bogdan Nagirniak added 1 commit 2023-05-19 15:56:15 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-05-19 15:56:40 +02:00
Brian Savery (AMD) approved these changes 2023-05-19 19:10:39 +02:00
Bogdan Nagirniak merged commit d14a315b7f into hydra-render 2023-05-19 20:19:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Georgiy Markelov
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#41
No description provided.
Delete Branch "BLEN-349"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?